netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Cc: netdev@vger.kernel.org, mkubecek@suse.cz, andrew@lunn.ch,
	corbet@lwn.net, sridhar.samudrala@intel.com,
	anthony.l.nguyen@intel.com
Subject: Re: [PATCH net-next v5] ethtool: add netlink based get rss support
Date: Wed, 23 Nov 2022 19:30:48 -0800	[thread overview]
Message-ID: <20221123193048.7a19d246@kernel.org> (raw)
In-Reply-To: <20221123184846.161964-1-sudheer.mogilappagari@intel.com>

On Wed, 23 Nov 2022 10:48:46 -0800 Sudheer Mogilappagari wrote:
> +  ``ETHTOOL_A_RSS_RINGS``              u32     Ring count

Let's not put the number of rings in RSS.

I keep having to explain to people how to calculate the correct number
of active RX rings. If the field is in the channels API hopefully
they'll just use it.

The max ring being in RXFH seems like a purely historic / legacy thing.

  parent reply	other threads:[~2022-11-24  3:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 18:48 [PATCH net-next v5] ethtool: add netlink based get rss support Sudheer Mogilappagari
2022-11-23 19:54 ` Michal Kubecek
2022-11-24  3:30 ` Jakub Kicinski [this message]
2022-11-25 22:19   ` Mogilappagari, Sudheer
2022-11-28 23:24     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123193048.7a19d246@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=corbet@lwn.net \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=sridhar.samudrala@intel.com \
    --cc=sudheer.mogilappagari@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).