From: Vladimir Oltean <olteanv@gmail.com>
To: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: stmmac compile error
Date: Fri, 25 Nov 2022 12:57:15 +0200 [thread overview]
Message-ID: <20221125105715.obo2vz6mkilmsva4@skbuf> (raw)
In-Reply-To: <Y4CK8n8AiwOOTRFJ@gvm01>
Hi Piergiorgio,
On Fri, Nov 25, 2022 at 10:29:22AM +0100, Piergiorgio Beruto wrote:
> Hello!
> I've just checked-out the latest changes from
> git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/master
> commit b084f6cc3563faf4f4d16c98852c0c734fe18914
>
> When compiling, I got the following error:
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function ‘stmmac_cmdline_opt’:
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7583:28: error: too many arguments to function ‘sysfs_streq’
> 7583 | } else if (sysfs_streq(opt, "pause:", 6)) {
> | ^~~~~~~~~~~
> In file included from ./include/linux/bitmap.h:11,
> from ./include/linux/cpumask.h:12,
> from ./include/linux/smp.h:13,
> from ./include/linux/lockdep.h:14,
> from ./include/linux/mutex.h:17,
> from ./include/linux/notifier.h:14,
> from ./include/linux/clk.h:14,
> from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:17:
> ./include/linux/string.h:185:13: note: declared here
> 185 | extern bool sysfs_streq(const char *s1, const char *s2);
> | ^~~~~~~~~~~
> make[6]: *** [scripts/Makefile.build:250: drivers/net/ethernet/stmicro/stmmac/stmmac_main.o] Error 1
>
> NOTE: I did not make any changes, it is a clean build.
> Anyone knows what this could be?
>
> Thank you,
> Piergiorgio
That's pretty sad. Something went terribly wrong with the review process of this patch.
https://patchwork.kernel.org/project/netdevbpf/patch/202211222009239312149@zte.com.cn/
I've sent a revert here:
https://patchwork.kernel.org/project/netdevbpf/patch/20221125105304.3012153-1-vladimir.oltean@nxp.com/
next prev parent reply other threads:[~2022-11-25 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 9:29 stmmac compile error Piergiorgio Beruto
2022-11-25 10:57 ` Vladimir Oltean [this message]
2022-11-28 21:09 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125105715.obo2vz6mkilmsva4@skbuf \
--to=olteanv@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox