stmmac compile error

stmmac compile error

[Piergiorgio Beruto]

Hello!
I've just checked-out the latest changes from
git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/master
commit b084f6cc3563faf4f4d16c98852c0c734fe18914

When compiling, I got the following error:

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function ‘stmmac_cmdline_opt’:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7583:28: error: too many arguments to function ‘sysfs_streq’
 7583 |                 } else if (sysfs_streq(opt, "pause:", 6)) {
      |                            ^~~~~~~~~~~
In file included from ./include/linux/bitmap.h:11,
                 from ./include/linux/cpumask.h:12,
                 from ./include/linux/smp.h:13,
                 from ./include/linux/lockdep.h:14,
                 from ./include/linux/mutex.h:17,
                 from ./include/linux/notifier.h:14,
                 from ./include/linux/clk.h:14,
                 from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:17:
./include/linux/string.h:185:13: note: declared here
  185 | extern bool sysfs_streq(const char *s1, const char *s2);
      |             ^~~~~~~~~~~
make[6]: *** [scripts/Makefile.build:250: drivers/net/ethernet/stmicro/stmmac/stmmac_main.o] Error 1

NOTE: I did not make any changes, it is a clean build.
Anyone knows what this could be?

Thank you,
Piergiorgio

Re: stmmac compile error

[Vladimir Oltean]

Hi Piergiorgio,

On Fri, Nov 25, 2022 at 10:29:22AM +0100, Piergiorgio Beruto wrote:
> Hello!
> I've just checked-out the latest changes from
> git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/master
> commit b084f6cc3563faf4f4d16c98852c0c734fe18914
> 
> When compiling, I got the following error:
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function ‘stmmac_cmdline_opt’:
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:7583:28: error: too many arguments to function ‘sysfs_streq’
>  7583 |                 } else if (sysfs_streq(opt, "pause:", 6)) {
>       |                            ^~~~~~~~~~~
> In file included from ./include/linux/bitmap.h:11,
>                  from ./include/linux/cpumask.h:12,
>                  from ./include/linux/smp.h:13,
>                  from ./include/linux/lockdep.h:14,
>                  from ./include/linux/mutex.h:17,
>                  from ./include/linux/notifier.h:14,
>                  from ./include/linux/clk.h:14,
>                  from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:17:
> ./include/linux/string.h:185:13: note: declared here
>   185 | extern bool sysfs_streq(const char *s1, const char *s2);
>       |             ^~~~~~~~~~~
> make[6]: *** [scripts/Makefile.build:250: drivers/net/ethernet/stmicro/stmmac/stmmac_main.o] Error 1
> 
> NOTE: I did not make any changes, it is a clean build.
> Anyone knows what this could be?
> 
> Thank you,
> Piergiorgio

That's pretty sad. Something went terribly wrong with the review process of this patch.
https://patchwork.kernel.org/project/netdevbpf/patch/202211222009239312149@zte.com.cn/
I've sent a revert here:
https://patchwork.kernel.org/project/netdevbpf/patch/20221125105304.3012153-1-vladimir.oltean@nxp.com/

Re: stmmac compile error

[Jakub Kicinski]

On Fri, 25 Nov 2022 12:57:15 +0200 Vladimir Oltean wrote:
> That's pretty sad. Something went terribly wrong with the review process of this patch.
> https://patchwork.kernel.org/project/netdevbpf/patch/202211222009239312149@zte.com.cn/

Do you mean that the build has passed? The code is under ifndef MODULE
and we build with allmodconfig :(