* [PATCH net] packet: do not set TP_STATUS_CSUM_VALID on CHECKSUM_COMPLETE
@ 2022-11-28 16:18 Willem de Bruijn
2022-11-29 17:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Willem de Bruijn @ 2022-11-28 16:18 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, edumazet, pabeni, al.drozdov, alexanderduyck,
Willem de Bruijn
From: Willem de Bruijn <willemb@google.com>
CHECKSUM_COMPLETE signals that skb->csum stores the sum over the
entire packet. It does not imply that an embedded l4 checksum
field has been validated.
Fixes: 682f048bd494 ("af_packet: pass checksum validation status to the user")
Signed-off-by: Willem de Bruijn <willemb@google.com>
---
net/packet/af_packet.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 6ce8dd19f33c..1ab65f7f2a0a 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -2293,8 +2293,7 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev,
if (skb->ip_summed == CHECKSUM_PARTIAL)
status |= TP_STATUS_CSUMNOTREADY;
else if (skb->pkt_type != PACKET_OUTGOING &&
- (skb->ip_summed == CHECKSUM_COMPLETE ||
- skb_csum_unnecessary(skb)))
+ skb_csum_unnecessary(skb))
status |= TP_STATUS_CSUM_VALID;
if (snaplen > res)
@@ -3520,8 +3519,7 @@ static int packet_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
if (skb->ip_summed == CHECKSUM_PARTIAL)
aux.tp_status |= TP_STATUS_CSUMNOTREADY;
else if (skb->pkt_type != PACKET_OUTGOING &&
- (skb->ip_summed == CHECKSUM_COMPLETE ||
- skb_csum_unnecessary(skb)))
+ skb_csum_unnecessary(skb))
aux.tp_status |= TP_STATUS_CSUM_VALID;
aux.tp_len = origlen;
--
2.38.1.584.g0f3c55d4c2-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] packet: do not set TP_STATUS_CSUM_VALID on CHECKSUM_COMPLETE
2022-11-28 16:18 [PATCH net] packet: do not set TP_STATUS_CSUM_VALID on CHECKSUM_COMPLETE Willem de Bruijn
@ 2022-11-29 17:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-29 17:00 UTC (permalink / raw)
To: Willem de Bruijn
Cc: netdev, davem, kuba, edumazet, pabeni, al.drozdov, alexanderduyck,
willemb
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 28 Nov 2022 11:18:12 -0500 you wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> CHECKSUM_COMPLETE signals that skb->csum stores the sum over the
> entire packet. It does not imply that an embedded l4 checksum
> field has been validated.
>
> Fixes: 682f048bd494 ("af_packet: pass checksum validation status to the user")
> Signed-off-by: Willem de Bruijn <willemb@google.com>
>
> [...]
Here is the summary with links:
- [net] packet: do not set TP_STATUS_CSUM_VALID on CHECKSUM_COMPLETE
https://git.kernel.org/netdev/net/c/b85f628aa158
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-29 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-28 16:18 [PATCH net] packet: do not set TP_STATUS_CSUM_VALID on CHECKSUM_COMPLETE Willem de Bruijn
2022-11-29 17:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).