From: Jakub Kicinski <kuba@kernel.org>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: Jiri Pirko <jiri@nvidia.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER
Date: Mon, 28 Nov 2022 18:14:30 -0800 [thread overview]
Message-ID: <20221128181430.2390b238@kernel.org> (raw)
In-Reply-To: <20221129020151.3842613-1-mailhol.vincent@wanadoo.fr>
On Tue, 29 Nov 2022 11:01:51 +0900 Vincent Mailhol wrote:
> As discussed in [1], abbreviating the bootloader to "bl" might not be
> well understood. Instead, a bootloader technically being a firmware,
> name it "fw.bootloader".
>
> Add a new macro to devlink.h to formalize this new info attribute
> name.
>
> [1] https://lore.kernel.org/netdev/20221128142723.2f826d20@kernel.org/
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
It's okay for this patch to go via the can tree, FWIW.
It may cause an extra delay for you if you have to wait
for the define to propagate.
Either way you should document the meaning of the parameter,
however obvious it may seem:
Documentation/networking/devlink/devlink-info.rst
next prev parent reply other threads:[~2022-11-29 2:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 2:01 [PATCH net-next] net: devlink: add DEVLINK_INFO_VERSION_GENERIC_FW_BOOTLOADER Vincent Mailhol
2022-11-29 2:14 ` Jakub Kicinski [this message]
2022-11-29 3:08 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128181430.2390b238@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).