From: Jakub Kicinski <kuba@kernel.org>
To: <Jerry.Ray@microchip.com>
Cc: <andrew@lunn.ch>, <f.fainelli@gmail.com>, <olteanv@gmail.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats
Date: Wed, 30 Nov 2022 08:52:26 -0800 [thread overview]
Message-ID: <20221130085226.16c1ffc3@kernel.org> (raw)
In-Reply-To: <MWHPR11MB1693E002721F0696949C5DCBEF159@MWHPR11MB1693.namprd11.prod.outlook.com>
On Wed, 30 Nov 2022 15:51:44 +0000 Jerry.Ray@microchip.com wrote:
>> Why not add them there as well?
>>
>> Are these drops accounted for in any drop / error statistics within
>> rtnl_link_stats?
>>
>> It's okay to provide implementation specific breakdown via ethtool -S
>> but user must be able to notice that there are some drops / errors in
>> the system by looking at standard stats.
>
> The idea here is to provide the statistics as documented in the part
> datasheet. In the future, I'll be looking to add support for the stats64
> API and will deal with appropriately sorting the available hardware stats
> into the rtnl_link_stats buckets.
Upstream we care about providing reasonably uniform experience across
drivers and vendors. Because I don't know you and therefore don't trust
you to follow up you must do the standard thing in the same patch set,
pretty please.
next prev parent reply other threads:[~2022-11-30 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 20:55 [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats Jerry Ray
2022-11-28 21:05 ` Vladimir Oltean
2022-11-30 15:57 ` Jerry.Ray
2022-11-30 16:00 ` Andrew Lunn
2022-11-28 23:21 ` Jakub Kicinski
2022-11-30 15:51 ` Jerry.Ray
2022-11-30 16:52 ` Jakub Kicinski [this message]
2022-11-30 18:12 ` Jerry.Ray
2022-11-30 18:50 ` Vladimir Oltean
2022-12-01 15:56 ` Jerry.Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130085226.16c1ffc3@kernel.org \
--to=kuba@kernel.org \
--cc=Jerry.Ray@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).