From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: zhang.songyi@zte.com.cn, saeedm@nvidia.com, pabeni@redhat.com,
davem@davemloft.net, edumazet@google.com, mbloch@nvidia.com,
maorg@nvidia.com, elic@nvidia.com, jerrliu@nvidia.com,
cmi@nvidia.com, vladbu@nvidia.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: remove NULL check before dev_{put, hold}
Date: Wed, 30 Nov 2022 09:25:16 -0800 [thread overview]
Message-ID: <20221130092516.024873db@kernel.org> (raw)
In-Reply-To: <Y4cbssiTgsGGNHlh@unreal>
On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote:
> On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote:
> > From: zhang songyi <zhang.songyi@zte.com.cn>
> >
> > The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> > so there is no need to check before using dev_{put, hold}.
> >
> > Fix the following coccicheck warning:
> > /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
> > WARNING:
> > WARNING NULL check before dev_{put, hold} functions is not needed.
> >
> > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Please change all places in mlx5 in one patch.
Your call as a mlx5 maintainer, but I'd say don't change them at all.
All these trivial patches are such a damn waste of time.
next prev parent reply other threads:[~2022-11-30 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 7:41 [PATCH net-next] net/mlx5: remove NULL check before dev_{put, hold} zhang.songyi
2022-11-30 9:00 ` Leon Romanovsky
2022-11-30 17:25 ` Jakub Kicinski [this message]
2022-11-30 19:13 ` Leon Romanovsky
2022-12-03 20:43 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130092516.024873db@kernel.org \
--to=kuba@kernel.org \
--cc=cmi@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elic@nvidia.com \
--cc=jerrliu@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=vladbu@nvidia.com \
--cc=zhang.songyi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).