From: <zhang.songyi@zte.com.cn>
To: <saeedm@nvidia.com>, <pabeni@redhat.com>
Cc: <leon@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
<kuba@kernel.org>, <mbloch@nvidia.com>, <maorg@nvidia.com>,
<elic@nvidia.com>, <jerrliu@nvidia.com>, <cmi@nvidia.com>,
<vladbu@nvidia.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<zhang.songyi@zte.com.cn>
Subject: [PATCH net-next] net/mlx5: remove NULL check before dev_{put, hold}
Date: Wed, 30 Nov 2022 15:41:27 +0800 (CST) [thread overview]
Message-ID: <202211301541270908055@zte.com.cn> (raw)
From: zhang songyi <zhang.songyi@zte.com.cn>
The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold}.
Fix the following coccicheck warning:
/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
index 32c3e0a649a7..6ab3a6b6dd8d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
@@ -1448,8 +1448,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev)
} else {
ndev = ldev->pf[MLX5_LAG_P1].netdev;
}
- if (ndev)
- dev_hold(ndev);
+ dev_hold(ndev);
unlock:
spin_unlock_irqrestore(&lag_lock, flags);
--
2.25.1
next reply other threads:[~2022-11-30 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 7:41 zhang.songyi [this message]
2022-11-30 9:00 ` [PATCH net-next] net/mlx5: remove NULL check before dev_{put, hold} Leon Romanovsky
2022-11-30 17:25 ` Jakub Kicinski
2022-11-30 19:13 ` Leon Romanovsky
2022-12-03 20:43 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211301541270908055@zte.com.cn \
--to=zhang.songyi@zte.com.cn \
--cc=cmi@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elic@nvidia.com \
--cc=jerrliu@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).