* [RESEND PATCH v1] drivers/net/bonding/bond_3ad: return when there's no aggregator
@ 2022-11-29 7:26 Daniil Tatianin
2022-12-01 5:46 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Daniil Tatianin @ 2022-11-29 7:26 UTC (permalink / raw)
To: netdev; +Cc: Daniil Tatianin, linux-kernel
Otherwise we would dereference a NULL aggregator pointer when calling
__set_agg_ports_ready on the line below.
Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
---
drivers/net/bonding/bond_3ad.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index acb6ff0be5ff..320e5461853f 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -1520,6 +1520,7 @@ static void ad_port_selection_logic(struct port *port, bool *update_slave_arr)
slave_err(bond->dev, port->slave->dev,
"Port %d did not find a suitable aggregator\n",
port->actor_port_number);
+ return;
}
}
/* if all aggregator's ports are READY_N == TRUE, set ready=TRUE
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <20221124080008.188175-1-d-tatianin@yandex-team.ru>]
* Re: [RESEND PATCH v1] drivers/net/bonding/bond_3ad: return when there's no aggregator
[not found] <20221124080008.188175-1-d-tatianin@yandex-team.ru>
@ 2022-11-28 20:37 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-11-28 20:37 UTC (permalink / raw)
To: Daniil Tatianin
Cc: Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, Eric Dumazet,
Paolo Abeni, netdev, linux-kernel, lvc-project, yc-core
On Thu, 24 Nov 2022 11:00:08 +0300 Daniil Tatianin wrote:
> Otherwise we would dereference a NULL aggregator pointer when calling
> __set_agg_ports_ready on the line below.
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
>
> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Did not make it to the list.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-01 5:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-29 7:26 [RESEND PATCH v1] drivers/net/bonding/bond_3ad: return when there's no aggregator Daniil Tatianin
2022-12-01 5:46 ` Jakub Kicinski
[not found] <20221124080008.188175-1-d-tatianin@yandex-team.ru>
2022-11-28 20:37 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).