From: Jakub Kicinski <kuba@kernel.org>
To: Daniele Palmas <dnlplm@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"Subash Abhinov Kasiviswanathan" <quic_subashab@quicinc.com>,
"Sean Tranchetti" <quic_stranche@quicinc.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Alexander Lobakin" <alexandr.lobakin@intel.com>,
"Gal Pressman" <gal@nvidia.com>, "Bjørn Mork" <bjorn@mork.no>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/3] ethtool: add tx aggregation parameters
Date: Thu, 1 Dec 2022 16:21:31 -0800 [thread overview]
Message-ID: <20221201162131.1f6c6188@kernel.org> (raw)
In-Reply-To: <20221130124616.1500643-2-dnlplm@gmail.com>
On Wed, 30 Nov 2022 13:46:14 +0100 Daniele Palmas wrote:
> Add the following ethtool tx aggregation parameters:
> diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> index bede24ef44fd..ac51a01b674d 100644
> --- a/Documentation/networking/ethtool-netlink.rst
> +++ b/Documentation/networking/ethtool-netlink.rst
> @@ -1002,6 +1002,9 @@ Kernel response contents:
> ``ETHTOOL_A_COALESCE_RATE_SAMPLE_INTERVAL`` u32 rate sampling interval
> ``ETHTOOL_A_COALESCE_USE_CQE_TX`` bool timer reset mode, Tx
> ``ETHTOOL_A_COALESCE_USE_CQE_RX`` bool timer reset mode, Rx
> + ``ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES`` u32 max aggr packets size, Tx
> + ``ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES`` u32 max aggr packets, Tx
> + ``ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS`` u32 time (us), aggr pkts, Tx
> =========================================== ====== =======================
Please double check make htmldocs does not generate warnings.
I think you went outside of the table bounds (further than
the ==== line)...
next prev parent reply other threads:[~2022-12-02 0:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 12:46 [PATCH net-next v2 0/3] add tx packets aggregation to ethtool and rmnet Daniele Palmas
2022-11-30 12:46 ` [PATCH net-next v2 1/3] ethtool: add tx aggregation parameters Daniele Palmas
2022-12-02 0:21 ` Jakub Kicinski [this message]
2022-12-02 11:42 ` Daniele Palmas
2022-11-30 12:46 ` [PATCH net-next v2 2/3] net: qualcomm: rmnet: add tx packets aggregation Daniele Palmas
2022-11-30 16:35 ` kernel test robot
2022-12-01 2:01 ` kernel test robot
2022-11-30 12:46 ` [PATCH net-next v2 3/3] net: qualcomm: rmnet: add ethtool support for configuring tx aggregation Daniele Palmas
2022-11-30 15:04 ` [PATCH net-next v2 0/3] add tx packets aggregation to ethtool and rmnet Dave Taht
2022-12-01 10:48 ` Daniele Palmas
2022-12-01 15:22 ` Dave Taht
2022-12-02 16:56 ` Daniele Palmas
2022-12-02 17:27 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201162131.1f6c6188@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=bjorn@mork.no \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dnlplm@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_stranche@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).