From: Lucas Stach <l.stach@pengutronix.de>
To: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, patchwork-lst@pengutronix.de
Subject: [PATCH 1/2] net: asix: Simplify return value check after asix_check_host_enable
Date: Thu, 1 Dec 2022 18:55:24 +0100 [thread overview]
Message-ID: <20221201175525.2733125-1-l.stach@pengutronix.de> (raw)
Any negative return value from this function is indicative of an
error. Simplify the condition to cover all possible error codes.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/net/usb/asix_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
index 72ffc89b477a..be1e103b7a95 100644
--- a/drivers/net/usb/asix_common.c
+++ b/drivers/net/usb/asix_common.c
@@ -504,7 +504,7 @@ static int __asix_mdio_read(struct net_device *netdev, int phy_id, int loc,
mutex_lock(&dev->phy_mutex);
ret = asix_check_host_enable(dev, in_pm);
- if (ret == -ENODEV || ret == -ETIMEDOUT) {
+ if (ret < 0) {
mutex_unlock(&dev->phy_mutex);
return ret;
}
@@ -542,7 +542,7 @@ static int __asix_mdio_write(struct net_device *netdev, int phy_id, int loc,
mutex_lock(&dev->phy_mutex);
ret = asix_check_host_enable(dev, in_pm);
- if (ret == -ENODEV)
+ if (ret < 0)
goto out;
ret = asix_write_cmd(dev, AX_CMD_WRITE_MII_REG, phy_id, (__u16)loc, 2,
--
2.30.2
next reply other threads:[~2022-12-01 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 17:55 Lucas Stach [this message]
2022-12-01 17:55 ` [PATCH 2/2] net: asix: Avoid looping when the device is diconnected Lucas Stach
2022-12-04 11:48 ` Leon Romanovsky
2022-12-06 1:17 ` Jakub Kicinski
2022-12-04 11:46 ` [PATCH 1/2] net: asix: Simplify return value check after asix_check_host_enable Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201175525.2733125-1-l.stach@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).