From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Yanhong Wang <yanhong.wang@starfivetech.com>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v1 3/7] dt-bindings: net: Add bindings for StarFive dwmac
Date: Thu, 1 Dec 2022 13:32:47 -0600 [thread overview]
Message-ID: <20221201193247.GA1190273-robh@kernel.org> (raw)
In-Reply-To: <Y4jl6awCMFgZsQGC@spud>
On Thu, Dec 01, 2022 at 05:35:37PM +0000, Conor Dooley wrote:
> On Thu, Dec 01, 2022 at 05:21:04PM +0100, Krzysztof Kozlowski wrote:
> > On 01/12/2022 10:02, Yanhong Wang wrote:
> > > Add bindings for the StarFive dwmac module on the StarFive RISC-V SoCs.
> >
> > Subject: drop second, redundant "bindings".
> >
> > >
> > > Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> > > ---
> > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 +
> > > +properties:
> > > + compatible:
> > > + oneOf:
> >
> > Drop oneOf. You do not have more cases here.
> >
> > > + - items:
> > > + - enum:
> > > + - starfive,dwmac
> >
> > Wrong indentation.... kind of expected since you did not test the bindings.
> >
> > > + - const: snps,dwmac-5.20
>
> Disclaimer: no familiarity with the version info with DW stuff
>
> Is it a bit foolish to call this binding "starfive,dwmac"? Could there
> not be another StarFive SoC in the future that uses another DW mac IP
> version & this would be better off as "starfive,jh7110-dwmac" or similar?
Yes. Really, *only* "starfive,jh7110-dwmac" is enough IMO.
The question is what would the OS do with only understanding
"snps,dwmac-5.20"? The answer is typically nothing because it isn't
enough information to act on. So that compatible is not needed. Maybe
the driver can do some things based on version, but that can be implied
from the compatible (if not read from a register). And often, the exact
version is not known, so do you want to hardcode a guess in DT? For
these reasons, we've moved away from using these generic IP compatibles
(with or without versions).
Rob
next prev parent reply other threads:[~2022-12-01 19:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 9:02 [PATCH v1 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2022-12-01 9:02 ` [PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version Yanhong Wang
2022-12-01 16:18 ` Krzysztof Kozlowski
2022-12-02 2:53 ` yanhong wang
2022-12-02 8:01 ` Krzysztof Kozlowski
2022-12-07 13:56 ` Emil Renner Berthing
2022-12-08 1:34 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 2/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2022-12-07 13:58 ` Emil Renner Berthing
2022-12-08 1:42 ` yanhong wang
2022-12-09 1:59 ` Ben Dooks
2022-12-09 2:26 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 3/7] dt-bindings: net: Add bindings for StarFive dwmac Yanhong Wang
2022-12-01 13:36 ` Rob Herring
2022-12-01 16:45 ` Conor Dooley
2022-12-02 10:52 ` Krzysztof Kozlowski
2022-12-01 16:21 ` Krzysztof Kozlowski
2022-12-01 17:35 ` Conor Dooley
2022-12-01 19:32 ` Rob Herring [this message]
2022-12-02 7:16 ` yanhong wang
2022-12-02 8:02 ` Krzysztof Kozlowski
2022-12-02 7:07 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 4/7] net: phy: motorcomm: Add YT8531 phy support Yanhong Wang
2022-12-01 15:40 ` Andrew Lunn
2022-12-06 7:39 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 5/7] net: stmmac: Add StarFive dwmac supoort Yanhong Wang
2022-12-07 14:16 ` Emil Renner Berthing
2022-12-08 2:22 ` yanhong wang
2022-12-09 2:03 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2022-12-01 17:45 ` Conor Dooley
2022-12-02 5:53 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 7/7] riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration Yanhong Wang
2022-12-01 17:49 ` Conor Dooley
2022-12-01 19:30 ` Conor Dooley
2022-12-01 19:42 ` Andrew Lunn
2022-12-09 1:28 ` yanhong wang
2022-12-09 1:19 ` yanhong wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201193247.GA1190273-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).