From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Aya Levin <ayal@nvidia.com>, Gal Pressman <gal@nvidia.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next 2/2] net/mlx5: Implement ptp_clock_info .getfine function
Date: Fri, 2 Dec 2022 12:15:31 -0800 [thread overview]
Message-ID: <20221202201528.26634-3-rrameshbabu@nvidia.com> (raw)
In-Reply-To: <20221202201528.26634-1-rrameshbabu@nvidia.com>
.getfine gives the driver the ability to report the frequency offset from
the device. The frequency offset from the nominal frequency is reported by
the driver in scaled 16-bit fractional parts-per-million.
Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Acked-by: Saeed Mahameed <saeedm@nvidia.com>
---
.../ethernet/mellanox/mlx5/core/lib/clock.c | 35 +++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
index 69cfe60c558a..4ecf67f617c0 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
@@ -326,6 +326,40 @@ static int mlx5_ptp_adjtime(struct ptp_clock_info *ptp, s64 delta)
return 0;
}
+static int mlx5_ptp_getfine(struct ptp_clock_info *ptp, long *scaled_ppm)
+{
+ struct mlx5_clock *clock = container_of(ptp, struct mlx5_clock, ptp_info);
+ u32 in[MLX5_ST_SZ_DW(mtutc_reg)] = {};
+ u32 out[MLX5_ST_SZ_DW(mtutc_reg)];
+ struct mlx5_core_dev *mdev;
+ s64 delta;
+ int err;
+
+ mdev = container_of(clock, struct mlx5_core_dev, clock);
+
+ err = mlx5_core_access_reg(mdev, in, sizeof(in), out, sizeof(out),
+ MLX5_REG_MTUTC, 0, 0);
+ if (err)
+ return err;
+
+ delta = MLX5_GET(mtutc_reg, out, freq_adjustment);
+ /* Convert parts-per-billion (10^-9) to parts-per-million (10^-6)
+ * with a 16 bit binary fractional field
+ *
+ * scaled_ppm = ppb * 2^16 / 1000
+ *
+ * which is equivalent to
+ *
+ * scaled_ppm = ppb * 2^13 / 125
+ */
+ delta <<= 13;
+ delta /= 125;
+
+ *scaled_ppm = delta;
+
+ return 0;
+}
+
static int mlx5_ptp_adjfreq_real_time(struct mlx5_core_dev *mdev, s32 freq)
{
u32 in[MLX5_ST_SZ_DW(mtutc_reg)] = {};
@@ -688,6 +722,7 @@ static const struct ptp_clock_info mlx5_ptp_clock_info = {
.n_pins = 0,
.pps = 0,
.adjfine = mlx5_ptp_adjfine,
+ .getfine = mlx5_ptp_getfine,
.adjtime = mlx5_ptp_adjtime,
.gettimex64 = mlx5_ptp_gettimex,
.settime64 = mlx5_ptp_settime,
--
2.36.2
next prev parent reply other threads:[~2022-12-02 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 20:15 [PATCH net-next 0/2] ptp: Introduce .getfine callback to ptp_clock_info Rahul Rameshbabu
2022-12-02 20:15 ` [PATCH net-next 1/2] ptp: Add .getfine function to support reporting frequency offset from hardware Rahul Rameshbabu
2022-12-02 20:15 ` Rahul Rameshbabu [this message]
2022-12-03 10:06 ` [PATCH net-next 2/2] net/mlx5: Implement ptp_clock_info .getfine function kernel test robot
2022-12-03 11:06 ` kernel test robot
2022-12-02 20:45 ` [PATCH net-next 0/2] ptp: Introduce .getfine callback to ptp_clock_info Richard Cochran
2022-12-02 22:11 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202201528.26634-3-rrameshbabu@nvidia.com \
--to=rrameshbabu@nvidia.com \
--cc=ayal@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).