From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>,
netdev@vger.kernel.org, mkubecek@suse.cz, andrew@lunn.ch,
corbet@lwn.net, sridhar.samudrala@intel.com,
anthony.l.nguyen@intel.com
Subject: Re: [PATCH net-next v7] ethtool: add netlink based get rss support
Date: Sun, 4 Dec 2022 15:38:50 -0800 [thread overview]
Message-ID: <20221204153850.42640ac2@kernel.org> (raw)
In-Reply-To: <Y4yPwR2vBSepDNE+@unreal>
On Sun, 4 Dec 2022 14:17:05 +0200 Leon Romanovsky wrote:
> On Thu, Dec 01, 2022 at 04:25:55PM -0800, Sudheer Mogilappagari wrote:
> > Add netlink based support for "ethtool -x <dev> [context x]"
> > command by implementing ETHTOOL_MSG_RSS_GET netlink message.
> > This is equivalent to functionality provided via ETHTOOL_GRSSH
> > in ioctl path. It sends RSS table, hash key and hash function
> > of an interface to user space.
> >
> > This patch implements existing functionality available
> > in ioctl path and enables addition of new RSS context
> > based parameters in future.
>
> But why do you do this conversion now? Was this "future" already
> discussed on the ML?
Conversion to netlink stands on its own.
> > + u8 *rss_config;
> > + int ret;
>
> <...>
>
> > + data->indir_table = (u32 *)rss_config;
>
> Please use correct type from the beginning.
There are two tables in this memory, the second one is u8.
So one of them will need the cast, the code is fine AFAICT.
next prev parent reply other threads:[~2022-12-04 23:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 0:25 [PATCH net-next v7] ethtool: add netlink based get rss support Sudheer Mogilappagari
2022-12-04 12:17 ` Leon Romanovsky
2022-12-04 23:38 ` Jakub Kicinski [this message]
2022-12-05 7:45 ` Leon Romanovsky
2022-12-06 1:33 ` Jakub Kicinski
2022-12-06 16:14 ` Michal Kubecek
2022-12-07 8:42 ` Leon Romanovsky
2022-12-07 9:32 ` Michal Kubecek
2022-12-08 8:22 ` Leon Romanovsky
2022-12-06 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221204153850.42640ac2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=leon@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).