From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89282C4708D for ; Mon, 5 Dec 2022 09:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbiLEJaT (ORCPT ); Mon, 5 Dec 2022 04:30:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229982AbiLEJaR (ORCPT ); Mon, 5 Dec 2022 04:30:17 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9049415738 for ; Mon, 5 Dec 2022 01:30:16 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id vp12so26264662ejc.8 for ; Mon, 05 Dec 2022 01:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=FDSrwTaiYkeBidVUL1wtnaARBnuugrDybG4J4B7KjRQ=; b=Ek0fC49oSagD3Ul+L5jopBmUBuROZhyg8VcZqkQLTLLSW289nCIWsDjmqkq4Lfw3jn 6JTFUVwUuz/ucY7tHQ7rjwKWqiLvK4QBoG2qCjn/7uTS+IxdOeI19s/gXRup1X8kZZTq NHkqvHENyjPX4T6Ko8Z0crqu/RPwk48aBb4ZhEv8pAjM1BZTGxx9FlYJfTEp57nCwAhy sB9Ntjtk70cgt8Zpy4oHiVoRCcCWyNwGuyvebX9d7ovvFMpTNf4VlyXVEl2QIm3wkPch s84BmvXPo33pDnXrac/2nfzR/irs9Ufr+UFiGKtljIbiwaTllL77iZJsEL4SSshmW1xY z4hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FDSrwTaiYkeBidVUL1wtnaARBnuugrDybG4J4B7KjRQ=; b=UkntLjNaR2Tb7PZ3EFuKrIh/Uhc7Nb5RmXvDAIYZfHiaeLVyHGqaLbaeIyZyOpQdP6 MD+ur4XsHC6qcTm4AYOFFWWmFvRwiupes3GcDPHkZs0cdl4UZRXiESPIJvUQP7NBLtlL ZyuM80qT7avpUmj18ma5PvE03600rlfUdOBMKcYby6Ajd1FyAIrsuy9wq0ymG0vxcjX1 pDpS78EVvGrKQoYgPf9If/p3t2LZiYezjUa2/ytelMWJ1ZkyAZHsGwlKc9SPf2AVR3ti SjTTYq3pLgBdZ8kMLev3/WK2/8FdkhsR9zP4GwblG2SK1deaLVd4PFAKT1pcKqT5FgG4 MymA== X-Gm-Message-State: ANoB5pnJSDupnBNwDgTCeCOXDLtzsOvzEydCbVOqiR15wclRbzVUZ8kS BTBs7NevfaMHXL8Nmu/G2D2LVw== X-Google-Smtp-Source: AA0mqf4TucuADXPXXqE+4vnUK9TP8V9mLlh1wYufLkkd/GzpBoGLKx7nJ3ZNqqhERafJoj9+vyiZjg== X-Received: by 2002:a17:906:a1a:b0:79e:9aea:7b60 with SMTP id w26-20020a1709060a1a00b0079e9aea7b60mr70679116ejf.444.1670232615061; Mon, 05 Dec 2022 01:30:15 -0800 (PST) Received: from blmsp ([185.238.219.11]) by smtp.gmail.com with ESMTPSA id o26-20020a170906289a00b007415f8ffcbbsm6136319ejd.98.2022.12.05.01.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 01:30:14 -0800 (PST) Date: Mon, 5 Dec 2022 10:30:13 +0100 From: Markus Schneider-Pargmann To: Marc Kleine-Budde Cc: Chandrasekar Ramakrishnan , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/15] can: tcan4x5x: Fix register range of first block Message-ID: <20221205093013.kpsqyb3fhd5njubm@blmsp> References: <20221116205308.2996556-1-msp@baylibre.com> <20221116205308.2996556-15-msp@baylibre.com> <20221202142810.kmd5m26fnm6lw2jh@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221202142810.kmd5m26fnm6lw2jh@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Marc, On Fri, Dec 02, 2022 at 03:28:10PM +0100, Marc Kleine-Budde wrote: > On 16.11.2022 21:53:07, Markus Schneider-Pargmann wrote: > > According to the datasheet 0x1c is the last register in the first block, > > not register 0x2c. > > The datasheet "SLLSF91A – DECEMBER 2018 – REVISED JANUARY 2020" says: > > | 8.6.1 Device ID and Interrupt/Diagnostic Flag Registers: 16'h0000 to > | 16'h002F > > While the last described register is at 0xc. Sorry, not sure what I looked up here. The last described register is 0x10 SPI Error status mask in my datasheet: 'SLLSEZ5D – JANUARY 2018 – REVISED JUNE 2022' I would prefer using the actual registers if that is ok with you, so 0x10 here because I assume the remaining registers have internal use or maybe don't exist at all?! If there is an undocumented register that needs to be used at some point we can still modify the ranges. Also it seems the existing ranges are following the same logic and don't list the whole range, just the documented registers. The second range is wrong as well. The last register is 0x830, will fix. Best, Markus