From: Stephen Hemminger <stephen@networkplumber.org>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
davem@davemloft.net, kuba@kernel.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
LiLiang <liali@redhat.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>
Subject: Re: [PATCH net] team: prevent ipv6 link local address on port devices
Date: Mon, 5 Dec 2022 10:39:05 -0800 [thread overview]
Message-ID: <20221205103905.1b2fa96a@hermes.local> (raw)
In-Reply-To: <32ee765d2240163f1cbd5d99db6233f276857ccb.1670262365.git.lucien.xin@gmail.com>
On Mon, 5 Dec 2022 12:46:05 -0500
Xin Long <lucien.xin@gmail.com> wrote:
> The similar fix from commit c2edacf80e15 ("bonding / ipv6: no addrconf
> for slaves separately from master") is also needed in Team. Otherwise,
> DAD and RS packets to be sent from the slaves in turn can confuse the
> switches and cause them to incorrectly update their forwarding tables
> as Liang noticed in the test with activebackup mode.
>
> Note that the patch also sets IFF_MASTER flag for Team dev accordingly
> while IFF_SLAVE flag is set for port devs. Although IFF_MASTER flag is
> not really used in Team, it's good to show in 'ip link':
>
> eth1: <BROADCAST,MULTICAST,SLAVE,UP,LOWER_UP>
> team0: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP>
>
> Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device")
> Reported-by: LiLiang <liali@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
The failover device probably needs the same changes.
Does anyone use the failover network device? Looks like KVM never got support for it.
next prev parent reply other threads:[~2022-12-05 18:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 17:46 [PATCH net] team: prevent ipv6 link local address on port devices Xin Long
2022-12-05 18:39 ` Stephen Hemminger [this message]
2022-12-06 8:05 ` Jiri Pirko
2022-12-06 13:32 ` Xin Long
2022-12-06 21:52 ` Xin Long
2022-12-07 13:31 ` Jiri Pirko
2022-12-07 23:35 ` Xin Long
2022-12-08 11:19 ` Jiri Pirko
2022-12-08 17:07 ` Xin Long
2022-12-09 11:11 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205103905.1b2fa96a@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).