From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E519AC4321E for ; Mon, 5 Dec 2022 21:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233902AbiLEVY5 (ORCPT ); Mon, 5 Dec 2022 16:24:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233342AbiLEVYe (ORCPT ); Mon, 5 Dec 2022 16:24:34 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE2B02CC94 for ; Mon, 5 Dec 2022 13:24:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670275471; x=1701811471; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Bqz0yQKvMarmUSeWVnuSZorZrIT1YJWATujzHCXh4dY=; b=PIvCQRXylvkptD1eX1mxb4uMvFzzFcQePvMtIDKjQrM828yOrm4hHAku f1KuDdbtBHAeu3CKjGAXIj83E7ziRFW8tE/V1iupGjGze4XOtNXFxciht iN93a02dNSi3Ddjm5NTyWFd2jnlD/Tu7J57dHtKUtY9qfwlltzVmutz4n bnmu4dy2SHlY1VjL9XGTguAk91Oa/+dMnLjMOUHayXBnCCKtEWJIk1FyA dWK1YdqcH2B8Azcy7U+Y4NJsTrHqL0rDgS8/OMlBe4aYvLL6iGHLPSd/O +f0aEWdzNlR++IqtKuDFmB7mzb5YyppyudjD1cFb/KouEY6aCcIbOiLSH Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="296157806" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="296157806" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 13:24:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="734744956" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="734744956" Received: from anguy11-desk2.jf.intel.com ([10.166.244.147]) by FMSMGA003.fm.intel.com with ESMTP; 05 Dec 2022 13:24:28 -0800 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com Cc: Muhammad Husaini Zulkifli , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, sasha.neftin@intel.com, Naama Meir Subject: [PATCH net-next 3/8] igc: Add checking for basetime less than zero Date: Mon, 5 Dec 2022 13:24:09 -0800 Message-Id: <20221205212414.3197525-4-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221205212414.3197525-1-anthony.l.nguyen@intel.com> References: <20221205212414.3197525-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Muhammad Husaini Zulkifli Using the tc qdisc command, the user can set basetime to any value. Checking should be done on the driver's side to prevent registering basetime values that are less than zero. Signed-off-by: Muhammad Husaini Zulkifli Tested-by: Naama Meir Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index eb4b916a609d..35c473703950 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -5934,6 +5934,9 @@ static int igc_save_qbv_schedule(struct igc_adapter *adapter, if (!qopt->enable) return igc_tsn_clear_schedule(adapter); + if (qopt->base_time < 0) + return -ERANGE; + if (adapter->base_time) return -EALREADY; -- 2.35.1