From: Divya Koppera <Divya.Koppera@microchip.com>
To: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <richardcochran@gmail.com>
Cc: <UNGLinuxDriver@microchip.com>
Subject: [PATCH v5 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret
Date: Tue, 6 Dec 2022 13:05:10 +0530 [thread overview]
Message-ID: <20221206073511.4772-2-Divya.Koppera@microchip.com> (raw)
In-Reply-To: <20221206073511.4772-1-Divya.Koppera@microchip.com>
Initialized return variable
Fixes Old smatch warnings:
drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
uninitialized symbol 'ret'.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 21b688dabecb ("net: phy: micrel: Cable Diag feature for lan8814 phy")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
---
v4 -> v5:
- No changes, added reviewed by tag.
v3 -> v4:
- Split the patch for different warnings.
v1 -> v3:
- No changes
---
drivers/net/phy/micrel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 26ce0c5defcd..1bcdb828db56 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -2088,7 +2088,8 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev,
const struct kszphy_type *type = phydev->drv->driver_data;
unsigned long pair_mask = type->pair_mask;
int retries = 20;
- int pair, ret;
+ int ret = 0;
+ int pair;
*finished = false;
--
2.17.1
next prev parent reply other threads:[~2022-12-06 7:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 7:35 [PATCH v5 net-next 0/2] Fixed warnings Divya Koppera
2022-12-06 7:35 ` Divya Koppera [this message]
2022-12-06 9:09 ` [PATCH v5 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Jiri Pirko
2022-12-06 7:35 ` [PATCH v5 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR Divya Koppera
2022-12-06 13:07 ` Andrew Lunn
2022-12-06 13:45 ` Divya.Koppera
2022-12-06 14:08 ` Andrew Lunn
2022-12-06 16:39 ` Richard Cochran
2022-12-12 8:34 ` Divya.Koppera
2022-12-12 10:11 ` Andrew Lunn
2022-12-13 9:55 ` Divya.Koppera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206073511.4772-2-Divya.Koppera@microchip.com \
--to=divya.koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).