From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79684C352A1 for ; Tue, 6 Dec 2022 19:50:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbiLFTuC (ORCPT ); Tue, 6 Dec 2022 14:50:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiLFTuB (ORCPT ); Tue, 6 Dec 2022 14:50:01 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B68DB2EF3E; Tue, 6 Dec 2022 11:50:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 621D8B81A2B; Tue, 6 Dec 2022 19:49:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9840EC433C1; Tue, 6 Dec 2022 19:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670356197; bh=n6Uq2l+P+LiuaIXlR0NKpX/qv3KPbggTYHrNNCyGgd0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=prwXr7EcJP6bfEzPvLBS9IMyn8Fmm4Ey8MmnFcDsY4cT/txnRCLlPNALfP6fc6oJw ThOfT/KkvKSnVry2UBLV9Xib+DQVGiFxA32LqOr7M67ZM8nqlv9A33Zb/6ZnHCahcE 9pcHHfdDKoe2FEvSIb6TWHpgbe05HxGxzLXklM2RQAfd/dnffWS9J+05OB8exlGTAd WaJo31TBn0AAzeYuutkmyzsueTrQaCzPxInjX/07xbU7jhT5J8aOuSUewDNa8gGlAL inJniHfo1d9eEYcA0EpZxFxWz6uzNE66RXQj9MxVfMyswaAebK+lLX4yZBx9rP2Uxm scrsx0FxZ+NxQ== Date: Tue, 6 Dec 2022 11:49:56 -0800 From: Jakub Kicinski To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Rasmus Villemoes , Jacob Keller , "David S . Miller" , edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.0 09/13] net: loopback: use NET_NAME_PREDICTABLE for name_assign_type Message-ID: <20221206114956.4c5a3605@kernel.org> In-Reply-To: <20221206094916.987259-9-sashal@kernel.org> References: <20221206094916.987259-1-sashal@kernel.org> <20221206094916.987259-9-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 6 Dec 2022 04:49:12 -0500 Sasha Levin wrote: > From: Rasmus Villemoes > > [ Upstream commit 31d929de5a112ee1b977a89c57de74710894bbbf ] > > When the name_assign_type attribute was introduced (commit > 685343fc3ba6, "net: add name_assign_type netdev attribute"), the > loopback device was explicitly mentioned as one which would make use > of NET_NAME_PREDICTABLE: > > The name_assign_type attribute gives hints where the interface name of a > given net-device comes from. These values are currently defined: > ... > NET_NAME_PREDICTABLE: > The ifname has been assigned by the kernel in a predictable way > that is guaranteed to avoid reuse and always be the same for a > given device. Examples include statically created devices like > the loopback device [...] > > Switch to that so that reading /sys/class/net/lo/name_assign_type > produces something sensible instead of returning -EINVAL. Yeah... we should have applied it to -next, I think backporting it is a good idea but I wish it had more time in the -next tree since it's a "uAPI alignment" :( Oh, well, very unlikely it will break anything, tho, so let's do it.