* [PATCH net] s390/qeth: fix use-after-free in hsci
@ 2022-12-06 14:56 Alexandra Winter
2022-12-07 8:36 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Alexandra Winter @ 2022-12-06 14:56 UTC (permalink / raw)
To: David Miller, Jakub Kicinski
Cc: netdev, linux-s390, Heiko Carstens, Alexandra Winter,
Thorsten Winkler, Wenjia Zhang
KASAN found that addr was dereferenced after br2dev_event_work was freed.
Fixes: f7936b7b2663 ("s390/qeth: Update MACs of LEARNING_SYNC device")
Reported-by: Thorsten Winkler <twinkler@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Reviewed-by: Thorsten Winkler <twinkler@linux.ibm.com>
---
drivers/s390/net/qeth_l2_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index 9dc935886e9f..c6ded3fdd715 100644
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -758,7 +758,6 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
struct list_head *iter;
int err = 0;
- kfree(br2dev_event_work);
QETH_CARD_TEXT_(card, 4, "b2dw%04lx", event);
QETH_CARD_TEXT_(card, 4, "ma%012llx", ether_addr_to_u64(addr));
@@ -815,6 +814,7 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
dev_put(brdev);
dev_put(lsyncdev);
dev_put(dstdev);
+ kfree(br2dev_event_work);
}
static int qeth_l2_br2dev_queue_work(struct net_device *brdev,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] s390/qeth: fix use-after-free in hsci
2022-12-06 14:56 [PATCH net] s390/qeth: fix use-after-free in hsci Alexandra Winter
@ 2022-12-07 8:36 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-12-07 8:36 UTC (permalink / raw)
To: Alexandra Winter
Cc: David Miller, Jakub Kicinski, netdev, linux-s390, Heiko Carstens,
Thorsten Winkler, Wenjia Zhang
On Tue, Dec 06, 2022 at 03:56:14PM +0100, Alexandra Winter wrote:
> KASAN found that addr was dereferenced after br2dev_event_work was freed.
Please add KASAN report to be part of commit message.
Thanks
>
> Fixes: f7936b7b2663 ("s390/qeth: Update MACs of LEARNING_SYNC device")
> Reported-by: Thorsten Winkler <twinkler@linux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
> Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
> Reviewed-by: Thorsten Winkler <twinkler@linux.ibm.com>
> ---
> drivers/s390/net/qeth_l2_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
> index 9dc935886e9f..c6ded3fdd715 100644
> --- a/drivers/s390/net/qeth_l2_main.c
> +++ b/drivers/s390/net/qeth_l2_main.c
> @@ -758,7 +758,6 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
> struct list_head *iter;
> int err = 0;
>
> - kfree(br2dev_event_work);
> QETH_CARD_TEXT_(card, 4, "b2dw%04lx", event);
> QETH_CARD_TEXT_(card, 4, "ma%012llx", ether_addr_to_u64(addr));
>
> @@ -815,6 +814,7 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
> dev_put(brdev);
> dev_put(lsyncdev);
> dev_put(dstdev);
> + kfree(br2dev_event_work);
> }
>
> static int qeth_l2_br2dev_queue_work(struct net_device *brdev,
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-07 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-06 14:56 [PATCH net] s390/qeth: fix use-after-free in hsci Alexandra Winter
2022-12-07 8:36 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).