From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
netdev@vger.kernel.org, peppe.cavallaro@st.com,
Voon Weifeng <weifeng.voon@intel.com>,
Rayagond Kokatanur <rayagond@vayavyalabs.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Antonio Borneo <antonio.borneo@st.com>,
Tan Tee Min <tee.min.tan@intel.com>,
Kurt Kanzenbach <kurt@linutronix.de>
Subject: Re: [PATCH net] stmmac: fix potential division by 0
Date: Tue, 6 Dec 2022 18:28:23 -0800 [thread overview]
Message-ID: <20221206182823.08e5f917@kernel.org> (raw)
In-Reply-To: <Y4i/Aeqh94ZP/mA0@lunn.ch>
On Thu, 1 Dec 2022 15:49:37 +0100 Andrew Lunn wrote:
> > The root cause is the MAC using the internal clock as a PTP reference
> > (default), which should be allowed since the connection to an external
> > PTP clock is optional from an HW perspective. The internal clock seems
> > to be derived from the MII clock speed, which is 2.5 MHz at 10 Mb/s.
>
> I think we need help from somebody who understands PTP on this device.
> The clock is clearly out of range, but how important is that to PTP?
> Will PTP work if the value is clamped to 0xff? Or should we be
> returning -EINVAL and disabling PTP because it has no chance of
> working?
Indeed, we need some more info here :( Like does the PTP actually
work with 2.5 MHz clock? The frequency adjustment only cares about
the addend, what is sub_second_inc thing?
next prev parent reply other threads:[~2022-12-07 2:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 0:37 [PATCH net] stmmac: fix potential division by 0 Piergiorgio Beruto
2022-12-01 1:39 ` Andrew Lunn
2022-12-01 10:24 ` Piergiorgio Beruto
2022-12-01 14:49 ` Andrew Lunn
2022-12-02 8:26 ` Piergiorgio Beruto
2022-12-07 2:28 ` Jakub Kicinski [this message]
2022-12-07 13:48 ` Andrew Lunn
2022-12-07 14:50 ` Kurt Kanzenbach
2022-12-08 0:26 ` Andrew Lunn
2022-12-08 9:27 ` Piergiorgio Beruto
2022-12-10 10:50 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206182823.08e5f917@kernel.org \
--to=kuba@kernel.org \
--cc=Jose.Abreu@synopsys.com \
--cc=andrew@lunn.ch \
--cc=antonio.borneo@st.com \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=rayagond@vayavyalabs.com \
--cc=tee.min.tan@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).