From: Jakub Kicinski <kuba@kernel.org>
To: Alex Elder <elder@ieee.org>
Cc: ye.xingchen@zte.com.cn, davem@davemloft.net, elder@kernel.org,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()
Date: Tue, 6 Dec 2022 18:53:29 -0800 [thread overview]
Message-ID: <20221206185329.092e37da@kernel.org> (raw)
In-Reply-To: <ff01f296-f3bb-4fdf-d57f-8dd14f1b61d2@ieee.org>
On Fri, 2 Dec 2022 16:20:16 -0600 Alex Elder wrote:
> On 12/2/22 2:42 AM, ye.xingchen@zte.com.cn wrote:
> > From: ye xingchen <ye.xingchen@zte.com.cn>
> >
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.
>
> The buffer passed is non-null and the existing code properly
> limits the buffer to PAGE_SIZE.
>
> But... OK.
>
> Reviewed-by: Alex Elder <elder@linaro.org>
>
Thanks! 38db82e2940 in net-next.
prev parent reply other threads:[~2022-12-07 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 8:42 [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf() ye.xingchen
2022-12-02 22:20 ` Alex Elder
2022-12-07 2:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206185329.092e37da@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).