From: Vladimir Oltean <olteanv@gmail.com>
To: Rakesh.Sankaranarayanan@microchip.com
Cc: kuba@kernel.org, andrew@lunn.ch, davem@davemloft.net,
Woojung.Huh@microchip.com, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, netdev@vger.kernel.org,
UNGLinuxDriver@microchip.com, edumazet@google.com,
pabeni@redhat.com, Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [RFC Patch net-next 3/5] net: dsa: microchip: add eth mac grouping for ethtool statistics
Date: Wed, 7 Dec 2022 15:21:07 +0200 [thread overview]
Message-ID: <20221207132107.3lefphupzpty4uoa@skbuf> (raw)
In-Reply-To: <6c1a53a825bee2b22f7e532885e6e777685c0726.camel@microchip.com>
On Fri, Dec 02, 2022 at 11:53:33AM +0000, Rakesh.Sankaranarayanan@microchip.com wrote:
> Hi Jakub,
>
> Thanks for the review comment.
>
> On Thu, 2022-12-01 at 20:02 -0800, Jakub Kicinski wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Wed, 30 Nov 2022 18:59:00 +0530 Rakesh Sankaranarayanan wrote:
> > > + mac_stats->FramesTransmittedOK = ctr[ksz9477_tx_mcast] +
> > > + ctr[ksz9477_tx_bcast] +
> > > + ctr[ksz9477_tx_ucast] +
> > > + ctr[ksz9477_tx_pause];
> >
> > do control frames count towards FramesTransmittedOK?
> > Please check the standard I don't recall.
> >
> Yeah, I will check with the documentation.
Oleksij said that the hardware counts pause frames for the byte
counters, so at least for consistency, they should be counted in frame
counters too.
https://patchwork.kernel.org/project/netdevbpf/patch/20221205052904.2834962-1-o.rempel@pengutronix.de/
next prev parent reply other threads:[~2022-12-07 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 13:28 [RFC Patch net-next 0/5] add ethtool categorized statistics Rakesh Sankaranarayanan
2022-11-30 13:28 ` [RFC Patch net-next 1/5] net: dsa: microchip: add rmon grouping for ethtool statistics Rakesh Sankaranarayanan
2022-12-07 13:23 ` Vladimir Oltean
2022-11-30 13:28 ` [RFC Patch net-next 2/5] net: dsa: microchip: add eth ctrl " Rakesh Sankaranarayanan
2022-11-30 13:29 ` [RFC Patch net-next 3/5] net: dsa: microchip: add eth mac " Rakesh Sankaranarayanan
2022-12-02 4:02 ` Jakub Kicinski
2022-12-02 11:53 ` Rakesh.Sankaranarayanan
2022-12-07 13:21 ` Vladimir Oltean [this message]
2022-11-30 13:29 ` [RFC Patch net-next 4/5] net: dsa: microchip: add eth phy " Rakesh Sankaranarayanan
2022-11-30 13:29 ` [RFC Patch net-next 5/5] net: dsa: microchip: remove num_alus variable Rakesh Sankaranarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207132107.3lefphupzpty4uoa@skbuf \
--to=olteanv@gmail.com \
--cc=Rakesh.Sankaranarayanan@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox