From: Jakub Kicinski <kuba@kernel.org>
To: <yang.yang29@zte.com.cn>
Cc: <edumazet@google.com>, <davem@davemloft.net>, <pabeni@redhat.com>,
<bigeasy@linutronix.de>, <imagedong@tencent.com>,
<kuniyu@amazon.com>, <petrm@nvidia.com>, <liu3101@purdue.edu>,
<wujianguo@chinatelecom.cn>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <tedheadster@gmail.com>
Subject: Re: [PATCH linux-next] net: record times of netdev_budget exhausted
Date: Wed, 7 Dec 2022 15:32:56 -0800 [thread overview]
Message-ID: <20221207153256.6c0ec51a@kernel.org> (raw)
In-Reply-To: <202212072030084707211@zte.com.cn>
On Wed, 7 Dec 2022 20:30:08 +0800 (CST) yang.yang29@zte.com.cn wrote:
> > Presumably, modern tracing techniques can let you do what you want
> > without adding new counters.
>
> By the way, should we add a tracepoint likes trace_napi_poll() to make
> it easier? Something likes:
> if (unlikely(budget <= 0 ||
> time_after_eq(jiffies, time_limit))) {
> sd->time_squeeze++;
> + trace_napi_poll(budget, jiffies, time_limit);
> break;
> }
In my experience - no this is not useful.
Sorry if this is too direct, but it seems to me like you're trying hard
to find something useful to do in this area without a clear use case.
We have coding tasks which would definitely be useful and which nobody
has time to accomplish. Please ask if you're trying to find something
to do.
next prev parent reply other threads:[~2022-12-07 23:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 8:12 [PATCH linux-next] net: record times of netdev_budget exhausted yang.yang29
2022-12-03 10:06 ` kernel test robot
2022-12-03 16:50 ` kernel test robot
2022-12-03 16:50 ` kernel test robot
2022-12-06 1:53 ` Jakub Kicinski
2022-12-06 2:35 ` yang.yang29
2022-12-06 2:47 ` Jakub Kicinski
2022-12-07 7:27 ` yang.yang29
2022-12-07 7:58 ` Eric Dumazet
2022-12-07 8:17 ` yang.yang29
2022-12-07 23:28 ` Jakub Kicinski
2022-12-07 12:30 ` yang.yang29
2022-12-07 23:32 ` Jakub Kicinski [this message]
2022-12-08 1:12 ` yang.yang29
2022-12-08 1:23 ` Jakub Kicinski
2022-12-08 1:42 ` yang.yang29
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207153256.6c0ec51a@kernel.org \
--to=kuba@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liu3101@purdue.edu \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=tedheadster@gmail.com \
--cc=wujianguo@chinatelecom.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).