From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Arun.Ramadoss@microchip.com,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, Eric Dumazet <edumazet@google.com>,
kernel@pengutronix.de, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next v1 1/1] net: dsa: microchip: add stats64 support for ksz8 series of switches
Date: Wed, 7 Dec 2022 15:48:26 -0800 [thread overview]
Message-ID: <20221207154826.5477008b@kernel.org> (raw)
In-Reply-To: <20221207061630.GC19179@pengutronix.de>
On Wed, 7 Dec 2022 07:16:30 +0100 Oleksij Rempel wrote:
> > FWIW for normal netdevs / NICs the rtnl_link_stat pkts do not include
> > pause frames, normally. Otherwise one can't maintain those stats in SW
> > (and per-ring stats, if any, don't add up to the full link stats).
> > But if you have a good reason to do this - I won't nack..
>
> Pause frames are accounted by rx/tx_bytes by HW. Since pause frames may
> have different size, it is not possible to correct byte counters, so I
> need to add them to the packet counters.
I have embarrassed myself with my lack of understanding of pause frames
before but nonetheless - are you sure? I thought they are always 64B.
Quick look at the standard seems to agree:
31C.3.1 Receive state diagram (INITIATE MAC CONTROL FUNCTION) for
EXTENSION operation
shows a 64 octet frame.
Sending long pause frames seems self-defeating as we presumably want
the receiver to react ASAP.
next prev parent reply other threads:[~2022-12-07 23:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 5:29 [PATCH net-next v1 1/1] net: dsa: microchip: add stats64 support for ksz8 series of switches Oleksij Rempel
2022-12-06 17:08 ` Vladimir Oltean
2022-12-07 6:14 ` Oleksij Rempel
2022-12-06 19:41 ` Jakub Kicinski
2022-12-07 6:16 ` Oleksij Rempel
2022-12-07 23:48 ` Jakub Kicinski [this message]
2022-12-08 5:55 ` Oleksij Rempel
2022-12-08 16:27 ` Jakub Kicinski
2022-12-08 16:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207154826.5477008b@kernel.org \
--to=kuba@kernel.org \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).