From: Jakub Kicinski <kuba@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org,
mkubecek@suse.cz
Subject: Re: [PATCH net-next v1 0/2] ethtool: use bits.h defines
Date: Wed, 7 Dec 2022 18:40:29 -0800 [thread overview]
Message-ID: <20221207184029.3996bc5f@kernel.org> (raw)
In-Reply-To: <20221207231728.2331166-1-jesse.brandeburg@intel.com>
On Wed, 7 Dec 2022 15:17:26 -0800 Jesse Brandeburg wrote:
> Change the ethtool files in the kernel, including uapi header files, to
> use the kernel style BIT() and BIT_ULL() functions instead of
> open-coding bit shift operations.
>
> Making this change results in a more consistent presentation of bit-
> shift operations as well as reduces the further likelihood of mistaken
> (1 << 31) usage which omits the 1UL that is necessary to get an unsigned
> result of the shift.
Let's hear some opinions but the BIT / GENMASK macros are not
universally loved so conversion == cleanup may not obvious.
next prev parent reply other threads:[~2022-12-08 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 23:17 [PATCH net-next v1 0/2] ethtool: use bits.h defines Jesse Brandeburg
2022-12-07 23:17 ` [PATCH net-next v1 1/2] ethtool/uapi: use BIT for bit-shifts Jesse Brandeburg
2022-12-08 2:41 ` Jakub Kicinski
2022-12-09 22:17 ` Jesse Brandeburg
2022-12-07 23:17 ` [PATCH net-next v1 2/2] ethtool: refactor bit-shifts Jesse Brandeburg
2022-12-08 2:40 ` Jakub Kicinski [this message]
2022-12-09 22:18 ` [PATCH net-next v1 0/2] ethtool: use bits.h defines Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207184029.3996bc5f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jesse.brandeburg@intel.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).