From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Saeed Mahameed <saeed@kernel.org>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Hans J. Schultz" <netdev@kapio-technology.com>
Subject: Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: replace ATU violation prints with trace points
Date: Thu, 8 Dec 2022 16:49:01 +0200 [thread overview]
Message-ID: <20221208144901.tgdhp73n7g5uh7qj@skbuf> (raw)
In-Reply-To: <Y5EsWNfVQrl8Nb71@x130>
On Wed, Dec 07, 2022 at 04:14:16PM -0800, Saeed Mahameed wrote:
> > if (val & MV88E6XXX_G1_ATU_OP_AGE_OUT_VIOLATION) {
> > - dev_err_ratelimited(chip->dev,
> > - "ATU age out violation for %pM fid %u\n",
> > - entry.mac, fid);
> > + trace_mv88e6xxx_atu_age_out_violation(chip->dev, spid,
> > + entry.mac, fid);
>
> no stats here? tracepoints are disabled by default and this event will go
> unnoticed, users usually monitor light weight indicators such as stats, then
> turn on tracepoints to see what's actually happening..
I believe that the ATU age out violation handler is dead code currently.
The driver does not enable the MV88E6XXX_PORT_ASSOC_VECTOR_INT_AGE_OUT bit
(interrupt on age out).
I just converted the existing debugging prints to trace points. Open to
more suggestions, but I believe that if I introduce a counter, it would
always return 0.
next prev parent reply other threads:[~2022-12-08 14:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 23:39 [PATCH net-next 0/3] Trace points for mv88e6xxx Vladimir Oltean
2022-12-07 23:39 ` [PATCH net-next 1/3] net: dsa: mv88e6xxx: read FID when handling ATU violations Vladimir Oltean
2022-12-07 23:39 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: replace ATU violation prints with trace points Vladimir Oltean
2022-12-08 0:14 ` Saeed Mahameed
2022-12-08 14:49 ` Vladimir Oltean [this message]
2022-12-08 15:22 ` netdev
2022-12-08 15:27 ` Vladimir Oltean
2022-12-08 15:35 ` netdev
2022-12-09 0:26 ` Saeed Mahameed
2022-12-08 18:33 ` netdev
2022-12-08 19:31 ` Vladimir Oltean
2022-12-07 23:39 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: replace VTU " Vladimir Oltean
2022-12-08 12:32 ` [PATCH net-next 0/3] Trace points for mv88e6xxx netdev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208144901.tgdhp73n7g5uh7qj@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@kapio-technology.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox