From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71BADC4167B for ; Fri, 9 Dec 2022 16:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiLIQeV (ORCPT ); Fri, 9 Dec 2022 11:34:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbiLIQeT (ORCPT ); Fri, 9 Dec 2022 11:34:19 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56F2F7720A for ; Fri, 9 Dec 2022 08:34:18 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0BD0EB82785 for ; Fri, 9 Dec 2022 16:34:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63DD3C433EF; Fri, 9 Dec 2022 16:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670603655; bh=LcoCY2/p6vLZBiPVrQpjHYeN+HYYqSMWhdzAQTEqwXU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ybnjg3sGCftGQoE2nGaTAY1LKn0FUAagfEcWVMrTlf/UQk6HLX5jYyD47c7qDM+QQ 0pPOC3NUFrfWL28mZ71LOml9sNiLUUgaSTUNc4dAr/TIWPvEV+lNUON9yiCc020qt9 EE46UkuoMTZa2NFYQ0wek8Eq+WgzxK3poBI1VPiotTdIS7e966XiGs5EPkVydAEp/n Vkw8CuAZ/RSY98y5bpyQsOjqroBBw7IC3PnDK+q+xh/to7qGnXO34dbkCdKQAPGJkG 0Z7DfJ5UL6VowQFqTC8ytVj6N+MCA+RJAPVr/hlB27PY9ZQLs6xBXD5n6/mpYbJI4Y vjDpL4JbLlEsQ== Date: Fri, 9 Dec 2022 08:34:14 -0800 From: Jakub Kicinski To: Saeed Mahameed Cc: Saeed Mahameed , "David S. Miller" , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, Tariq Toukan , Moshe Shemesh , Mark Bloch Subject: Re: [net-next 14/15] net/mlx5: SRIOV, Add 802.1ad VST support Message-ID: <20221209083414.4f6f1aac@kernel.org> In-Reply-To: References: <20221203221337.29267-1-saeed@kernel.org> <20221203221337.29267-15-saeed@kernel.org> <20221206203414.1eaf417b@kernel.org> <20221207092517.3320f4b4@kernel.org> <20221208170459.538917da@kernel.org> <20221208180442.2b2452fb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 8 Dec 2022 21:05:23 -0800 Saeed Mahameed wrote: > >I see, but that's the fix? Uniformly drop? > >Start stacking with just .1q? > >Auto-select the ethtype for .1ad if there's already a tag? > > push the vst .1q tag. keep original tags intact. > per policy we won't have .1ad support :( .. Yup, stacking another .1q sounds okay to me. Not exactly standard-compliant but I bet there's already a device out there which does exactly this so meh..