From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2792C4332F for ; Fri, 9 Dec 2022 14:16:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229919AbiLIOQi (ORCPT ); Fri, 9 Dec 2022 09:16:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbiLIOQQ (ORCPT ); Fri, 9 Dec 2022 09:16:16 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16DC664D0; Fri, 9 Dec 2022 06:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670595353; x=1702131353; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Q4a9U1SZ0Rp7ftX9JdBYHlEBnCnbX6tXmyOibpHi2+M=; b=IravYnSqmliil7Q4B85Nd9h4Mtewnm9OVLHxgEC9vHtLFY0Hv+cQe6gG 2YyYFQG7mFAK5/l4i1OuA69wFUkcIzmPZU8EUPcgU76vo6VxdCs2NQ0kw peCHh/khoDt6JVk40idnE6NOO65S6GRE1jBJO9Ylcv0zQMQ643ytRCk0T vMqN22ub2z3R9tzIr9v18TFqGuY7/4PWhdfd4nZBHCasm0np7BOxuKHFe jnWlgP0Mp+Xsc+MksXx6tUbv6gxh0xnJZ5s2ODbmNxqx+pLwJzY7kCm0S /GguS3lFTdJA5O4OwWXt8cuUrQu/pm9se/XRu2dbP6GveWefjQX4+5+oa A==; X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="190897842" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Dec 2022 07:15:52 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 9 Dec 2022 07:15:51 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 9 Dec 2022 07:15:51 -0700 Date: Fri, 9 Dec 2022 15:20:58 +0100 From: Horatiu Vultur To: Michael Walle CC: Vladimir Oltean , , , , , , , , , , , , Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209142058.ww7aijhsr76y3h2t@soft-dev3-1> References: <20221203104348.1749811-5-horatiu.vultur@microchip.com> <20221208092511.4122746-1-michael@walle.cc> <20221208130444.xshazhpg4e2utvjs@soft-dev3-1> <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The 12/09/2022 15:05, Michael Walle wrote: > > Am 2022-12-09 13:56, schrieb Vladimir Oltean: > > On Fri, Dec 09, 2022 at 01:58:57PM +0100, Horatiu Vultur wrote: > > > > Does it also work out of the box with the following patch if > > > > the interface is part of a bridge or do you still have to do > > > > the tc magic from above? > > > > > > You will still need to enable the TCAM using the tc command to have it > > > working when the interface is part of the bridge. > > > > FWIW, with ocelot (same VCAP mechanism), PTP traps work out of the box, > > no need to use tc. Same goes for ocelot-8021q, which also uses the > > VCAP. > > I wouldn't consider forcing the user to add any tc command in order for > > packet timestamping to work properly. On ocelot, the vcap is enabled at port initialization, while on other platforms(lan966x and sparx5) you have the option to enable or disable. > > +1 > Esp. because there is no warning. I.e. I tried this patch while > the interface was added on a bridge and there was no error > whatsoever. What error/warning were you expecting to see here? > Also, you'd force the user to have that Kconfig option > set. > > -michael > -- /Horatiu