From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A46EC4332F for ; Fri, 9 Dec 2022 14:52:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbiLIOwY (ORCPT ); Fri, 9 Dec 2022 09:52:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbiLIOwW (ORCPT ); Fri, 9 Dec 2022 09:52:22 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE0DE31F99; Fri, 9 Dec 2022 06:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670597541; x=1702133541; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=soL3nnB0D4xyE+xbuKsXWiTXpWmeQbH/LNwKxozF2SA=; b=N4SVX0O8v18jAIKUFme3fiYcbZqghjuUpzYjk9qjN3bqHqG7lj3SX2ay pwEN3LsXjGbq3K95FeaUIIJYaHEj4iiDBLiDpM4lw0lUsuSA0bYVrFLb9 0NdX8TC7h+6MdycbE3VuXf64UiFCv15g8AF+l5vT+xmVoXm81lJedzn4C sV+FDgqwiVRVzf0WL292Xz10jxZhKy7iIKnFGvguI82z6xZ66+cl2Fg40 yAGDUuFjdYDoCj15RXptW11GNCspxqqpJxd2iP0qGOV9a2aplT8JcpuyT ZXMDlyMq057fzML8kbob9CgYRAntSpv+b2/SsRw5Fn3X+GC3zXDWiePyP g==; X-IronPort-AV: E=Sophos;i="5.96,230,1665471600"; d="scan'208";a="190901720" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Dec 2022 07:52:21 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 9 Dec 2022 07:52:13 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Fri, 9 Dec 2022 07:52:13 -0700 Date: Fri, 9 Dec 2022 15:57:20 +0100 From: Horatiu Vultur To: Vladimir Oltean CC: Michael Walle , , , , , , , , , , , , Subject: Re: [PATCH net-next v3 4/4] net: lan966x: Add ptp trap rules Message-ID: <20221209145720.ahjmercylzqo5tla@soft-dev3-1> References: <20221208130444.xshazhpg4e2utvjs@soft-dev3-1> <20221209092904.asgka7zttvdtijub@soft-dev3-1> <20221209125857.yhsqt4nj5kmavhmc@soft-dev3-1> <20221209125611.m5cp3depjigs7452@skbuf> <20221209142058.ww7aijhsr76y3h2t@soft-dev3-1> <20221209144328.m54ksmoeitmcjo5f@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20221209144328.m54ksmoeitmcjo5f@skbuf> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The 12/09/2022 16:43, Vladimir Oltean wrote: > > On Fri, Dec 09, 2022 at 03:20:58PM +0100, Horatiu Vultur wrote: > > On ocelot, the vcap is enabled at port initialization, while on other > > platforms(lan966x and sparx5) you have the option to enable or disable. > > Even if that wasn't the case, I'd still consider enabling/disabling VCAP > lookups privately in the ocelot driver when there are non-tc users of > traps, instead of requiring users to do anything with tc. I was thinking also about this, such the ptp to enable the VCAP privately. But then the issue would be if a user adds entries using tc and then start ptp, then suddently the rules that were added using tc could be hit. That is the reason why expected the user to enable the tcam manually. > It's simply too unfriendly for somebody who just wants PTP. You can use > devlink traps to show which non-tc traps are active. -- /Horatiu