Re: [Patch net-next v3 02/13] net: dsa: microchip: ptp: Initial hardware time stamping support

Vladimir Oltean
2022-12-09T15:20:06Z

On Fri, Dec 09, 2022 at 12:54:26PM +0530, Arun Ramadoss wrote:
> From: Christian Eggers <ceggers@arri.de>
>
> This patch adds the routine for get_ts_info, hwstamp_get, set. This enables
> the PTP support towards userspace applications such as linuxptp.
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> Co-developed-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>
>

When you resend, could you also do something about these blank lines
after your sign off, here and in other patches? They shouldn't be there.
I think that a blank line will appear between this and other maintainer
sign offs.

> ---
> v1 -> v2
> - Declared the ksz_hwtstamp_get/set to NULL as macro if ptp is not
> enabled
> - Removed mutex lock in hwtstamp_set()