From: Jakub Kicinski <kuba@kernel.org>
To: Max Georgiev <glipus@gmail.com>
Cc: Michal Kubecek <mkubecek@suse.cz>, netdev@vger.kernel.org
Subject: Re: [PATCH ethtool] JSON output support for Netlink implementation of --show-coalesce option
Date: Fri, 9 Dec 2022 20:01:50 -0800 [thread overview]
Message-ID: <20221209200150.18490ed6@kernel.org> (raw)
In-Reply-To: <CAP5jrPHr2UMpKK45NTUVLtW9OiBctZhWP-0yVvb9_SBO3pC7LA@mail.gmail.com>
On Fri, 9 Dec 2022 19:16:10 -0700 Max Georgiev wrote:
> JSON output support for Netlink implementation of --show-coalesce option
>
> Add --json support for Netlink implementation of --show-coalesce option
> No changes for non-JSON output for this feature.
Nice!
> Same output with --json:
> $ sudo ./ethtool --json --show-coalesce enp9s0u2u1u2
> [ {
> "ifname": "enp9s0u2u1u2",
> "rx-usecs: ": 15000,
> "tx-usecs: ": 0
looks like we have double spurious ': ' in the key?
> + if (silent && !is_json_context())
> putchar('\n');
perhaps we can use show_cr() here as well?
> + print_uint(PRINT_JSON, label, NULL,
> mnl_attr_get_u32(attr));
> + } else {
This looks line-wrapped, perhaps try git send-email for v2?
Also subject should say [PATCH ethtool-next], since it's for
the "next" release.
prev parent reply other threads:[~2022-12-10 4:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 2:16 [PATCH ethtool] JSON output support for Netlink implementation of --show-coalesce option Max Georgiev
2022-12-10 4:01 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209200150.18490ed6@kernel.org \
--to=kuba@kernel.org \
--cc=glipus@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).