From: Willy Tarreau <w@1wt.eu>
To: Jens Axboe <axboe@kernel.dk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
netdev <netdev@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [GIT PULL] Add support for epoll min wait time
Date: Sat, 10 Dec 2022 16:58:11 +0100 [thread overview]
Message-ID: <20221210155811.GA22540@1wt.eu> (raw)
In-Reply-To: <b0901cba-3cb8-a309-701e-7b8cb13f0e8a@kernel.dk>
Hi Jens,
On Sat, Dec 10, 2022 at 08:36:11AM -0700, Jens Axboe wrote:
> Hi Linus,
>
> I've had this done for months and posted a few times, but little
> attention has been received.
I personally think this is particularly cool, for having faced the
same needs in the past. I'm just wondering how long we'll avoid the
need for marking certain FDs as urgent (i.e. for inter-thread wakeup)
which would bypass the min delay.
I'm just seeing something a bit odd in this series:
> ----------------------------------------------------------------
> epoll-min_ts-2022-12-08
>
> ----------------------------------------------------------------
> Jens Axboe (8):
> eventpoll: cleanup branches around sleeping for events
> eventpoll: don't pass in 'timed_out' to ep_busy_loop()
> eventpoll: split out wait handling
> eventpoll: move expires to epoll_wq
> eventpoll: move file checking earlier for epoll_ctl()
> eventpoll: add support for min-wait
> eventpoll: add method for configuring minimum wait on epoll context
> eventpoll: ensure we pass back -EBADF for a bad file descriptor
This last patch fixes a bug introduced by the 5th one. Why not squash it
instead of purposely introducing a bug then its fix ? Or maybe it was
just overlooked when you sent the PR ?
Thanks,
Willy
next prev parent reply other threads:[~2022-12-10 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 15:36 [GIT PULL] Add support for epoll min wait time Jens Axboe
2022-12-10 15:58 ` Willy Tarreau [this message]
2022-12-10 16:05 ` Jens Axboe
2022-12-10 16:17 ` Willy Tarreau
2022-12-10 16:23 ` Jens Axboe
2022-12-10 18:51 ` Linus Torvalds
2022-12-10 19:26 ` Linus Torvalds
2022-12-11 2:03 ` Jens Axboe
2022-12-11 1:58 ` Jens Axboe
2022-12-11 2:20 ` Jens Axboe
2022-12-11 2:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221210155811.GA22540@1wt.eu \
--to=w@1wt.eu \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).