From: Vladimir Oltean <olteanv@gmail.com>
To: Jerry.Ray@microchip.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
jbe@pengutronix.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk
Subject: Re: [PATCH net-next v5 5/6] dsa: lan9303: Determine CPU port based on dsa_switch ptr
Date: Mon, 12 Dec 2022 20:36:52 +0200 [thread overview]
Message-ID: <20221212183652.7wtzgcvtjgwsqwbr@skbuf> (raw)
In-Reply-To: <MWHPR11MB1693284A37657C11F91ADFD0EFE29@MWHPR11MB1693.namprd11.prod.outlook.com>
On Mon, Dec 12, 2022 at 05:42:01PM +0000, Jerry.Ray@microchip.com wrote:
> > It looks like there is potentially more code to unlock than this simple
> > API change, which is something you could look at.
>
> I understand your point. The LAN9303 is very flexible, supporting an I2C
> method for managing the switch and allowing the xMII to operate as either
> MAC or PHY.
>
> The original driver was written targeting the primary configuration most
> widely used by our customers. The host CPU has an xMII interface and the
> MDIO bus is used for control. Adding in the flexibility to support other
> configurations is something I will investigate as I expand the driver to
> support LAN9353/LAN9354/LAN9355 devices. Adding the
> private->info->supports_mii[] as was done in the ksz drivers is the most
> likely approach. I see this as a separate patch series. Would you agree?
>
> I will hardcode for port 0 at this point rather than looking at CPU port.
Yes, I think that would be ok. Thanks for at least not baking in any
more assumptions in the driver that already exist.
next prev parent reply other threads:[~2022-12-12 18:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 22:47 [PATCH net-next v5 0/6] dsa: lan9303: Move to PHYLINK Jerry Ray
2022-12-09 22:47 ` [PATCH net-next v5 1/6] dsa: lan9303: align dsa_switch_ops members Jerry Ray
2022-12-09 22:47 ` [PATCH net-next v5 2/6] dsa: lan9303: move Turbo Mode bit initialization Jerry Ray
2022-12-10 4:13 ` Jakub Kicinski
2022-12-09 22:47 ` [PATCH net-next v5 3/6] dsa: lan9303: Add exception logic for read failure Jerry Ray
2022-12-09 22:47 ` [PATCH net-next v5 4/6] dsa: lan9303: Performance Optimization Jerry Ray
2022-12-12 18:43 ` Vladimir Oltean
2022-12-09 22:47 ` [PATCH net-next v5 5/6] dsa: lan9303: Determine CPU port based on dsa_switch ptr Jerry Ray
2022-12-11 22:46 ` Vladimir Oltean
2022-12-12 17:42 ` Jerry.Ray
2022-12-12 18:36 ` Vladimir Oltean [this message]
2022-12-09 22:47 ` [PATCH net-next v5 6/6] dsa: lan9303: Migrate to PHYLINK Jerry Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212183652.7wtzgcvtjgwsqwbr@skbuf \
--to=olteanv@gmail.com \
--cc=Jerry.Ray@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jbe@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox