From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<Steen.Hegelund@microchip.com>, <daniel.machon@microchip.com>,
<lars.povlsen@microchip.com>, <UNGLinuxDriver@microchip.com>,
kernel test robot <lkp@intel.com>,
"Dan Carpenter" <error27@gmail.com>
Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask
Date: Tue, 13 Dec 2022 08:35:45 +0100 [thread overview]
Message-ID: <20221213073545.vuel5l6k7cej6xk6@soft-dev3-1> (raw)
In-Reply-To: <20221212130224.19bf695f@kernel.org>
The 12/12/2022 13:02, Jakub Kicinski wrote:
>
> On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote:
> > case VCAP_FIELD_U128:
> > + value = data->u128.value;
> > + mask = data->u128.value;
>
> If setting both to value is intentional - please mention in the commit
> message. Otherwise this looks odd.
It should not be both set to value. Will fix this in th next version.
--
/Horatiu
prev parent reply other threads:[~2022-12-13 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 12:07 [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask Horatiu Vultur
2022-12-09 23:19 ` Saeed Mahameed
2022-12-12 21:02 ` Jakub Kicinski
2022-12-13 7:35 ` Horatiu Vultur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213073545.vuel5l6k7cej6xk6@soft-dev3-1 \
--to=horatiu.vultur@microchip.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox