From: Jakub Kicinski <kuba@kernel.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: <peppe.cavallaro@st.com>, <alexandre.torgue@foss.st.com>,
<joabreu@synopsys.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<mcoquelin.stm32@gmail.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <boon.leong.ong@intel.com>,
<netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] net: stmmac: fix possible memory leak in stmmac_dvr_probe()
Date: Tue, 13 Dec 2022 19:15:28 -0800 [thread overview]
Message-ID: <20221213191528.75cd2ff0@kernel.org> (raw)
In-Reply-To: <20221212021350.3066631-1-cuigaosheng1@huawei.com>
On Mon, 12 Dec 2022 10:13:50 +0800 Gaosheng Cui wrote:
> The bitmap_free() should be called to free priv->af_xdp_zc_qps
> when create_singlethread_workqueue() fails, otherwise there will
> be a memory leak, so we add the err path error_wq_init to fix it.
>
> Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
The previous version has already been applied and we can't remove it.
Could you send an incremental change to just add the errno?
next prev parent reply other threads:[~2022-12-14 3:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 2:13 [PATCH v2] net: stmmac: fix possible memory leak in stmmac_dvr_probe() Gaosheng Cui
2022-12-14 3:15 ` Jakub Kicinski [this message]
2022-12-14 3:55 ` cuigaosheng
2022-12-14 3:57 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213191528.75cd2ff0@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=ast@kernel.org \
--cc=boon.leong.ong@intel.com \
--cc=cuigaosheng1@huawei.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).