[PATCH] net: phy: enhance Maxlinear GPY loopback disable function

[PATCH] net: phy: enhance Maxlinear GPY loopback disable function

[Xu Liang]

GPY need 3 seconds to switch out of loopback mode.

Signed-off-by: Xu Liang <lxu@maxlinear.com>
---
 drivers/net/phy/mxl-gpy.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index 147d7a5a9b35..81ea7c768657 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c
@@ -770,9 +770,10 @@ static int gpy_loopback(struct phy_device *phydev, bool enable)
 			 enable ? BMCR_LOOPBACK : 0);
 	if (!ret) {
 		/* It takes some time for PHY device to switch
-		 * into/out-of loopback mode.
+		 * into/out-of loopback mode. It takes 3 seconds
+		 * before re-enter loopback mode.
 		 */
-		msleep(100);
+		msleep(enable ? 100 : 3000);
 	}
 
 	return ret;
-- 
2.17.1

Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function

[Michael Walle]

Subject is missing the correct target, "net" in this case.

> GPY need 3 seconds to switch out of loopback mode.

What does that mean, what goes wrong with the current 100ms?
Could you elaborate a bit more and update the commit message
and the comment? Is this true for any GPY PHY supported by
this driver?

This probably needs a Fixed tag then.

-michael

Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function

[Russell King (Oracle)]

Hi,

On Wed, Dec 14, 2022 at 09:16:46AM +0000, Liang Xu wrote:
> From: Michael Walle <michael@walle.cc>
> Sent: Wednesday, December 14, 2022 5:00 PM
> Subject: Re: [PATCH] net: phy: enhance Maxlinear GPY loopback disable function
> 
> This email was sent from outside of MaxLinear.
> 
> 
> Subject is missing the correct target, "net" in this case.
> 
> > GPY need 3 seconds to switch out of loopback mode.
> 
> What does that mean, what goes wrong with the current 100ms?
> Could you elaborate a bit more and update the commit message
> and the comment? Is this true for any GPY PHY supported by
> this driver?
> 
> The internal state machine need almost 3s to fully restore to original state when leaving the loopback mode.
> This is true for all models supported by this driver.
> I will update the commit message and fix the target.
> Thank you.

When you state that it takes almost 3 seconds to fully restore the
state, what are you basing that upon - what are you using to determine
that the state has been fully restored?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!