From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD389C001B2 for ; Wed, 14 Dec 2022 12:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238464AbiLNMgT (ORCPT ); Wed, 14 Dec 2022 07:36:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238424AbiLNMf5 (ORCPT ); Wed, 14 Dec 2022 07:35:57 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02B8213F93; Wed, 14 Dec 2022 04:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671021254; x=1702557254; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gLUmLxK/mwLgHaeh9UkBdZ9YGpWxeUp7JgHpb5LXdic=; b=Kc8ofrMAROV/GHCMIe845KKqAg5nG5w1Sq/xbiwHeOMaSpdGs3MH4Ymn 8IB/0AHC8yQfmPyhOFGvJVhzU5pIfpCq6H2QMm4jNQxEaMgp8PPs2UzTa w5JSmGofyNpS17+oUB4KYI9zInMwvH5hXuq3PVsO+tKdh/D2KZrGzuHCs nCWEEHARafv+Q7TQuS9/oy92jX5yGcn9tkUjyRZ6yLGweD4u/EPgoMtPO ReSnscCE7Wkljehw/o9uKBLN7NG5ZoWe19l1h2XENkemLYckAghrm5GtZ Jp2UUgyI6b9H4/1bLzmWY7vUYGc0qPPejd2LX09kBnQcW2ZvngTBnjpN7 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="345460237" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="345460237" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 04:34:12 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="823243981" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="823243981" Received: from joe-255.igk.intel.com (HELO localhost) ([172.22.229.67]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 04:34:00 -0800 Date: Wed, 14 Dec 2022 13:33:58 +0100 From: Stanislaw Gruszka To: "Jason A. Donenfeld" Cc: david.keisarschm@mail.huji.ac.il, Vignesh Raghavendra , Peter Zijlstra , Dave Hansen , Rasmus Villemoes , Alexei Starovoitov , dri-devel@lists.freedesktop.org, Song Liu , Eric Dumazet , linux-mtd@lists.infradead.org, Stanislav Fomichev , Miquel Raynal , Roman Gushchin , Christoph Lameter , "H. Peter Anvin" , Daniel Borkmann , Richard Weinberger , x86@kernel.org, John Fastabend , Andrii Nakryiko , ilay.bahat1@gmail.com, Ingo Molnar , Steven Rostedt , Jiri Pirko , David Rientjes , Yonghong Song , Paolo Abeni , intel-gfx@lists.freedesktop.org, Petr Mladek , Jiri Olsa , Hao Luo , "James E.J. Bottomley" , KP Singh , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jakub Kicinski , Borislav Petkov , Hannes Reinecke , Andy Lutomirski , Rodrigo Vivi , Thomas Gleixner , Andy Shevchenko , Andrew Morton , Vlastimil Babka , Tvrtko Ursulin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Pekka Enberg , Sergey Senozhatsky , aksecurity@gmail.com, Joonsoo Kim , Martin KaFai Lau , "David S. Miller" Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state Message-ID: <20221214123358.GA1062210@linux.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > Please CC me on future revisions. > > As of 6.2, the prandom namespace is *only* for predictable randomness. > There's no need to rename anything. So nack on this patch 1/5. It is not obvious (for casual developers like me) that p in prandom stands for predictable. Some renaming would be useful IMHO. Regards Stanislaw