From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
"David S. Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Denis V. Lunev <den@openvz.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,"
<netdev@vger.kernel.org>
Subject: Re: [PATCH v1 net] af_unix: Add error handling in af_unix_init().
Date: Wed, 14 Dec 2022 14:36:13 -0800 [thread overview]
Message-ID: <20221214143613.316aace2@kernel.org> (raw)
In-Reply-To: <CAKgT0UcDsUOD_rhg9tzWVJkiL+ihwcuvZQ-_6ovRcwT79j6NKw@mail.gmail.com>
On Wed, 14 Dec 2022 14:27:23 -0800 Alexander Duyck wrote:
> > We ask people to add the "start of history" tag when the issue goes all
> > the way back.
>
> The point I was getting at is that this issue doesn't really go all
> the way back. Essentially sock_register could only fail if you were
> registering a proto over 32 or one that was already registered. So
> with 2.6.12-rc2 we should never see a failure without modifications to
> the kernel as we only register PF_UNIX once and the other functions at
> that time were void. This makes all the fixes tags suspect since the
> patch doesn't resolve any issue with that code.
>
> More likely candidates would have been:
> Fixes: 94531cfcbe79 ("af_unix: Add unix_stream_proto for sockmap")
> Fixes: 097e66c57845 ("[NET]: Make AF_UNIX per network namespace safe [v2]")
I see! Makes sense.
next prev parent reply other threads:[~2022-12-14 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 9:20 [PATCH v1 net] af_unix: Add error handling in af_unix_init() Kuniyuki Iwashima
2022-12-14 19:18 ` Alexander H Duyck
[not found] ` <20221214130131.17555240@kernel.org>
2022-12-14 22:27 ` Alexander Duyck
2022-12-14 22:36 ` Jakub Kicinski [this message]
2022-12-14 20:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214143613.316aace2@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).