From: Jakub Kicinski <kuba@kernel.org>
To: Maxim Georgiev <glipus@gmail.com>
Cc: mkubecek@suse.cz, netdev@vger.kernel.org
Subject: Re: [PATCH ethtool-next v2 v2] JSON output support for Netlink implementation of --show-coalesce option
Date: Wed, 14 Dec 2022 20:22:13 -0800 [thread overview]
Message-ID: <20221214202213.36ab31c0@kernel.org> (raw)
In-Reply-To: <20221215035651.65759-1-glipus@gmail.com>
On Wed, 14 Dec 2022 20:56:51 -0700 Maxim Georgiev wrote:
> Add --json support for Netlink implementation of --show-coalesce option
> No changes for non-JSON output for this featire.
s/featire/feature/
I'd add another sentence here, something like:
Note that all callers of show_u32() have to be updated but only
coalesce is converted fully.
To make it clear that the interspersed printf()s don't matter.
One small nit pick below:
> @@ -92,7 +113,12 @@ int nl_gcoalesce(struct cmd_context *ctx)
> ETHTOOL_A_COALESCE_HEADER, 0);
> if (ret < 0)
> return ret;
> - return nlsock_send_get_request(nlsk, coalesce_reply_cb);
> +
> + new_json_obj(ctx->json);
> + ret = nlsock_send_get_request(nlsk, coalesce_reply_cb);
> + delete_json_obj();
> + return ret;
> +
> }
Empty line befre closing bracket unnecessary.
next prev parent reply other threads:[~2022-12-15 4:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 3:56 [PATCH ethtool-next v2 v2] JSON output support for Netlink implementation of --show-coalesce option Maxim Georgiev
2022-12-15 4:22 ` Jakub Kicinski [this message]
2022-12-15 5:11 ` Max Georgiev
2022-12-15 5:13 ` [PATCH ethtool-next v3 v3] " Maxim Georgiev
2022-12-15 20:07 ` Jakub Kicinski
2022-12-20 17:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214202213.36ab31c0@kernel.org \
--to=kuba@kernel.org \
--cc=glipus@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).