From: Guillaume Nault <gnault@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: "Benjamin Coddington" <bcodding@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Josef Bacik" <josef@toxicpanda.com>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Lee Duncan" <lduncan@suse.com>,
"Chris Leech" <cleech@redhat.com>,
"Mike Christie" <michael.christie@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Valentina Manea" <valentina.manea.m@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Marc Dionne" <marc.dionne@auristor.com>,
"Steve French" <sfrench@samba.org>,
"Christine Caulfield" <ccaulfie@redhat.com>,
"David Teigland" <teigland@redhat.com>,
"Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Eric Van Hensbergen" <ericvh@gmail.com>,
"Latchesar Ionkov" <lucho@ionkov.net>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Xiubo Li" <xiubli@redhat.com>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anna Schumaker" <anna@kernel.org>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v3 2/3] Treewide: Stop corrupting socket's task_frag
Date: Thu, 15 Dec 2022 16:37:53 +0100 [thread overview]
Message-ID: <20221215153753.GA7408@pc-4.home> (raw)
In-Reply-To: <139538.1671115012@warthog.procyon.org.uk>
On Thu, Dec 15, 2022 at 02:36:52PM +0000, David Howells wrote:
>
> Guillaume Nault <gnault@redhat.com> wrote:
>
> > Maybe setting sk_use_task_frag in fs/afs/rxrpc.c was overzealous but
> > I'm not familiar enough with the AF_RXRPC family to tell. If AF_RXRPC
> > sockets can't call sk_page_frag() and have no reason to do so in the
> > future, then it should be safe to drop this chunk.
>
> As of this merge window, AF_RXRPC doesn't actually allocate sk_buffs apart
> from when it calls skb_unshare(). It does steal the incoming sk_buffs from
> the UDP socket it uses as a transport, but they're allocated in the IP/IP6
> stack somewhere.
>
> The UDP transport socket, on the other hand, will allocate sk_buffs for
> transmission, but rxrpc sends an entire UDP packet at a time, each with a
> single sendmsg call.
>
> Further, this mostly now moved such that the UDP sendmsg calls are performed
> inside an I/O thread. The application thread does not interact directly with
> the UDP transport socket.
>
> David
Thanks for the explanations. Looks like we could drop the fs/afs/rxrpc.c
chunk then.
prev parent reply other threads:[~2022-12-15 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 11:10 [PATCH net v3 0/3] Stop corrupting socket's task_frag Benjamin Coddington
2022-12-13 11:10 ` [PATCH net v3 1/3] net: Introduce sk_use_task_frag in struct sock Benjamin Coddington
2022-12-15 12:08 ` Paolo Abeni
2022-12-13 11:10 ` [PATCH net v3 2/3] Treewide: Stop corrupting socket's task_frag Benjamin Coddington
2022-12-13 11:10 ` [PATCH net v3 3/3] net: simplify sk_page_frag Benjamin Coddington
2022-12-15 12:12 ` [PATCH net v3 2/3] Treewide: Stop corrupting socket's task_frag David Howells
2022-12-15 13:59 ` Guillaume Nault
2022-12-15 14:36 ` David Howells
2022-12-15 15:37 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221215153753.GA7408@pc-4.home \
--to=gnault@redhat.com \
--cc=anna@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=bcodding@redhat.com \
--cc=ccaulfie@redhat.com \
--cc=christoph.boehmwalder@linbit.com \
--cc=chuck.lever@oracle.com \
--cc=cleech@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=idryomov@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=lduncan@suse.com \
--cc=lucho@ionkov.net \
--cc=marc.dionne@auristor.com \
--cc=mark@fasheh.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=philipp.reisner@linbit.com \
--cc=sagi@grimberg.me \
--cc=sfrench@samba.org \
--cc=shuah@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=teigland@redhat.com \
--cc=trond.myklebust@hammerspace.com \
--cc=valentina.manea.m@gmail.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).