From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Winter <Thomas.Winter@alliedtelesis.co.nz>
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
kuba@kernel.org, a@unstable.cc, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address
Date: Sun, 18 Dec 2022 14:16:38 -0800 [thread overview]
Message-ID: <20221218141638.41d8d32f@hermes.local> (raw)
In-Reply-To: <20221218215718.1491444-2-Thomas.Winter@alliedtelesis.co.nz>
On Mon, 19 Dec 2022 10:57:17 +1300
Thomas Winter <Thomas.Winter@alliedtelesis.co.nz> wrote:
> + switch (dev->type) {
> + #if IS_ENABLED(CONFIG_IPV6_SIT)
> + case ARPHRD_SIT:
> + addrconf_sit_config(dev);
> + break;
> + #endif
> + #if IS_ENABLED(CONFIG_NET_IPGRE) || IS_ENABLED(CONFIG_IPV6_GRE)
> + case ARPHRD_IP6GRE:
> + case ARPHRD_IPGRE:
> + addrconf_gre_config(dev);
> + break;
> + #endif
Linux kernel style is to start any conditional compilation in first column
I.e.
#if IS_ENABLED(CONFIG_IPV6_SIT)
Not
#if IS_ENABLED(CONFIG_IPV6_SIT)
next prev parent reply other threads:[~2022-12-18 22:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 21:57 [PATCH 0/2] ip/ip6_gre: Fix GRE tunnels not generating IPv6 link local addresses Thomas Winter
2022-12-18 21:57 ` [PATCH 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address Thomas Winter
2022-12-18 22:16 ` Stephen Hemminger [this message]
2022-12-18 21:57 ` [PATCH 2/2] ip/ip6_gre: Fix non-point-to-point tunnel " Thomas Winter
-- strict thread matches above, loose matches on Subject: below --
2022-12-19 1:06 [PATCH 0/2] ip/ip6_gre: Fix GRE tunnels not generating IPv6 link local addresses Thomas Winter
2022-12-19 1:06 ` [PATCH 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address Thomas Winter
2022-12-20 13:16 ` Paolo Abeni
2023-01-03 22:28 ` Thomas Winter
2023-01-24 3:21 [PATCH 0/2] ip/ip6_gre: Fix GRE tunnels not generating IPv6 link local addresses Thomas Winter
2023-01-24 3:21 ` [PATCH 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address Thomas Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221218141638.41d8d32f@hermes.local \
--to=stephen@networkplumber.org \
--cc=Thomas.Winter@alliedtelesis.co.nz \
--cc=a@unstable.cc \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox