From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC50C4332F for ; Sun, 18 Dec 2022 16:56:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232238AbiLRQ4Q (ORCPT ); Sun, 18 Dec 2022 11:56:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232941AbiLRQyx (ORCPT ); Sun, 18 Dec 2022 11:54:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0332F1C10A; Sun, 18 Dec 2022 08:19:18 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C2AA5B80BD9; Sun, 18 Dec 2022 16:19:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20E32C43443; Sun, 18 Dec 2022 16:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671380354; bh=CYFCy9x7yJd5X+PG94szVTvrV8aExaRAAvBUGpgSx+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KyFxveIJQLGJjre3/vpYJ2PJ1Tvww7is3O6a5/h3qqrklsymnJ5qWPh5k6z1swNvG 8bLc4l+rUEr7VXNL4CY/3uxxPf6csZuoYFAfrY7DCXmwa95/ie+B57HMEw9aoY5CBN /fOGrohdwbm3NNc/XjX7io6Ehrg7tyVa947hQnr0cJC84h8TIS1mflSF1bKqIFEfS+ niNvf5HXVf+uBYfFuP9bxmKGvaYBj9AqZd60gSxOdxgvbxRPmTMxF1Yl1cRYXP6fAl QPbQdJGaxNHP4qYJ85RitzJ3UdJgipQ/Rp2Bi72fQ0jKNUUvmIZtGTzNTQ1gIVGbBI 9V2z/2dGqkrpQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kees Cook , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, "Michael J . Ruhl" , Jacob Keller , Gurucharan , Sasha Levin Subject: [PATCH AUTOSEL 5.4 11/30] igb: Do not free q_vector unless new one was allocated Date: Sun, 18 Dec 2022 11:18:16 -0500 Message-Id: <20221218161836.933697-11-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221218161836.933697-1-sashal@kernel.org> References: <20221218161836.933697-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Kees Cook [ Upstream commit 0668716506ca66f90d395f36ccdaebc3e0e84801 ] Avoid potential use-after-free condition under memory pressure. If the kzalloc() fails, q_vector will be freed but left in the original adapter->q_vector[v_idx] array position. Cc: Jesse Brandeburg Cc: Tony Nguyen Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-by: Kees Cook Reviewed-by: Michael J. Ruhl Reviewed-by: Jacob Keller Tested-by: Gurucharan (A Contingent worker at Intel) Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index f718eadd8774..666676445d57 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -1213,8 +1213,12 @@ static int igb_alloc_q_vector(struct igb_adapter *adapter, if (!q_vector) { q_vector = kzalloc(size, GFP_KERNEL); } else if (size > ksize(q_vector)) { - kfree_rcu(q_vector, rcu); - q_vector = kzalloc(size, GFP_KERNEL); + struct igb_q_vector *new_q_vector; + + new_q_vector = kzalloc(size, GFP_KERNEL); + if (new_q_vector) + kfree_rcu(q_vector, rcu); + q_vector = new_q_vector; } else { memset(q_vector, 0, size); } -- 2.35.1