From: Jakub Kicinski <kuba@kernel.org>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH bpf 2/2] selftests/bpf: tunnel: add sanity test for checksums
Date: Tue, 20 Dec 2022 15:36:01 -0800 [thread overview]
Message-ID: <20221220153601.5f16545b@kernel.org> (raw)
In-Reply-To: <7372590a-f40b-17d1-f780-3bd1ce4f30bb@linux.dev>
On Tue, 20 Dec 2022 15:21:08 -0800 Martin KaFai Lau wrote:
> Thanks for the fix and the idea on how to test it.
>
> I have posted a patch to translate this test to a test for test_progs that can
> finish and exit such that it can be run continuously in CI. The test attaches a
> tc-bpf at lo and the bpf prog directly checks for the skb->ip_summed ==
> CHECKSUM_NONE and the broken csum_start condition.
>
> If the test_progs patch looks good, patch 1 can be landed first and then land
> the test_progs patch. wdyt?
I'm not attached to the test, your patch looks good!
next prev parent reply other threads:[~2022-12-20 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 0:47 [PATCH bpf 1/2] bpf: pull before calling skb_postpull_rcsum() Jakub Kicinski
2022-12-20 0:47 ` [PATCH bpf 2/2] selftests/bpf: tunnel: add sanity test for checksums Jakub Kicinski
2022-12-20 23:13 ` [PATCH bpf] selftests/bpf: Test bpf_skb_adjust_room on CHECKSUM_PARTIAL Martin KaFai Lau
2022-12-20 23:21 ` [PATCH bpf 2/2] selftests/bpf: tunnel: add sanity test for checksums Martin KaFai Lau
2022-12-20 23:36 ` Jakub Kicinski [this message]
2022-12-20 1:21 ` [PATCH bpf 1/2] bpf: pull before calling skb_postpull_rcsum() Stanislav Fomichev
2022-12-20 1:45 ` Jakub Kicinski
2022-12-20 1:55 ` Stanislav Fomichev
2022-12-21 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220153601.5f16545b@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).