netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Delevoryas <peter@pjd.dev>
To: unlisted-recipients:; (no To-header on input)
Cc: peter@pjd.dev, sam@mendozajonas.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	joel@jms.id.au, gwshan@linux.vnet.ibm.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command
Date: Tue, 20 Dec 2022 21:22:43 -0800	[thread overview]
Message-ID: <20221221052246.519674-1-peter@pjd.dev> (raw)

NC-SI 1.2 isn't officially released yet, but the DMTF takes way too long
to finalize stuff, and there's hardware out there that actually supports
this command (Just the Broadcom 200G NIC afaik).

The work in progress spec document is here:

https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.2WIP90_0.pdf

The command code is 0x58, the command has no data, and the response
returns a variable-length array of MAC addresses for the BMC.

I've tested this out using QEMU emulation (I added the Mellanox OEM Get
MAC Address command to libslirp a while ago [1], although the QEMU code
to use it is still not in upstream QEMU [2] [3]. I worked on some more
emulation code for this as well), and on the new Broadcom 200G NIC.

The Nvidia ConnectX-7 NIC doesn't support NC-SI 1.2 yet afaik. Neither
do older versions in newer firmware, they all just report NC-SI 1.1.

Let me know what I can do to change this patch to be more suitable for
upstreaming, I'm happy to work on it more!

Thanks,
Peter

[1] https://gitlab.freedesktop.org/slirp/libslirp/-/blob/0dd7f05095c0a77d9d2ec4764e8617192b4fa6ec/src/ncsi.c#L59
[2] https://github.com/facebook/openbmc/blob/a33dbcc25759f00baf113fd497c8d9db60eeed9e/common/recipes-devtools/qemu/qemu/0003-slirp-Add-mfr-id-to-netdev-options.patch
[3] https://github.com/facebook/openbmc/blob/a33dbcc25759f00baf113fd497c8d9db60eeed9e/common/recipes-devtools/qemu/qemu/0004-slirp-Add-oob-eth-addr-to-netdev-options.patch

Peter Delevoryas (3):
  net/ncsi: Simplify Kconfig/dts control flow
  net/ncsi: Fix netlink major/minor verison numbers
  net/ncsi: Add NC-SI 1.2 Get MC MAC Address command

 net/ncsi/internal.h     |  7 ++--
 net/ncsi/ncsi-cmd.c     |  3 +-
 net/ncsi/ncsi-manage.c  | 29 ++++++-----------
 net/ncsi/ncsi-netlink.c |  4 +--
 net/ncsi/ncsi-pkt.h     | 17 ++++++++--
 net/ncsi/ncsi-rsp.c     | 71 +++++++++++++++++++++++++++++++++++++++--
 6 files changed, 102 insertions(+), 29 deletions(-)

-- 
2.30.2


             reply	other threads:[~2022-12-21  5:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21  5:22 Peter Delevoryas [this message]
2022-12-21  5:22 ` [PATCH 1/3] net/ncsi: Simplify Kconfig/dts control flow Peter Delevoryas
2022-12-21  5:22 ` [PATCH 2/3] net/ncsi: Fix netlink major/minor version numbers Peter Delevoryas
2022-12-21  5:22 ` [PATCH 3/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command Peter Delevoryas
2022-12-22 10:53   ` Paolo Abeni
2022-12-22 17:18     ` Peter Delevoryas
2022-12-22 10:44 ` [PATCH 0/3] " Paolo Abeni
2022-12-22 17:13   ` Peter Delevoryas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221052246.519674-1-peter@pjd.dev \
    --to=peter@pjd.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=joel@jms.id.au \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sam@mendozajonas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).