From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCHv2 net-next] sched: multicast sched extack messages
Date: Wed, 21 Dec 2022 17:28:17 -0800 [thread overview]
Message-ID: <20221221172817.0da16ffa@kernel.org> (raw)
In-Reply-To: <20221221093940.2086025-1-liuhangbin@gmail.com>
On Wed, 21 Dec 2022 17:39:40 +0800 Hangbin Liu wrote:
> + nlh = nlmsg_put(skb, portid, n->nlmsg_seq, NLMSG_ERROR, sizeof(*errmsg),
> + NLM_F_ACK_TLVS | NLM_F_CAPPED);
> + if (!nlh)
> + return -1;
> +
> + errmsg = (struct nlmsgerr *)nlmsg_data(nlh);
> + errmsg->error = 0;
> + errmsg->msg = *n;
> +
> + if (nla_put_string(skb, NLMSGERR_ATTR_MSG, extack->_msg))
> + return -1;
> +
> + nlmsg_end(skb, nlh);
I vote "no", notifications should not generate NLMSG_ERRORs.
(BTW setting pid and seq on notifications is odd, no?)
next prev parent reply other threads:[~2022-12-22 1:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 9:39 [PATCHv2 net-next] sched: multicast sched extack messages Hangbin Liu
2022-12-22 1:28 ` Jakub Kicinski [this message]
2022-12-22 7:48 ` Hangbin Liu
2022-12-22 16:26 ` David Ahern
2022-12-23 2:35 ` Hangbin Liu
2022-12-26 16:31 ` Jamal Hadi Salim
2022-12-27 3:58 ` Hangbin Liu
2022-12-27 16:23 ` Jamal Hadi Salim
2022-12-28 8:41 ` Hangbin Liu
2022-12-31 13:48 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221172817.0da16ffa@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=liuhangbin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).