From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
maxime.coquelin@redhat.com, alvaro.karsz@solid-run.com,
eperezma@redhat.com
Subject: [RFC PATCH 2/4] virtio_ring: switch to use BAD_RING()
Date: Thu, 22 Dec 2022 14:04:25 +0800 [thread overview]
Message-ID: <20221222060427.21626-3-jasowang@redhat.com> (raw)
In-Reply-To: <20221222060427.21626-1-jasowang@redhat.com>
Switch to reuse BAD_RING() to allow common logic to be implemented in
BAD_RING().
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/virtio/virtio_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 2e7689bb933b..90c2034a77f3 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -2237,7 +2237,7 @@ bool virtqueue_notify(struct virtqueue *_vq)
/* Prod other side to tell it about changes. */
if (!vq->notify(_vq)) {
- vq->broken = true;
+ BAD_RING(vq, "vq %d is broken\n", vq->vq.index);
return false;
}
return true;
--
2.25.1
next prev parent reply other threads:[~2022-12-22 6:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 6:04 [RFC PATCH 0/4] virtio-net: don't busy poll for cvq command Jason Wang
2022-12-22 6:04 ` [RFC PATCH 1/4] virtio-net: convert rx mode setting to use workqueue Jason Wang
2022-12-22 6:04 ` Jason Wang [this message]
2022-12-22 6:04 ` [RFC PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue Jason Wang
2022-12-22 6:04 ` [RFC PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command Jason Wang
2022-12-22 6:44 ` Alvaro Karsz
2022-12-22 8:43 ` Jason Wang
2022-12-22 15:54 ` Alvaro Karsz
2022-12-23 3:00 ` Jason Wang
2022-12-23 7:38 ` Alvaro Karsz
2022-12-26 3:45 ` Jason Wang
2022-12-22 9:19 ` Eugenio Perez Martin
2022-12-23 3:03 ` Jason Wang
2022-12-23 8:04 ` Eugenio Perez Martin
2022-12-26 3:44 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221222060427.21626-3-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).