From: Stephen Hemminger <stephen@networkplumber.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] r8169: disable ASPM in case of tx timeout
Date: Wed, 28 Dec 2022 14:05:09 -0800 [thread overview]
Message-ID: <20221228140509.21b14e7b@hermes.local> (raw)
In-Reply-To: <1847c5aa-39ff-4574-b1c5-38ac5f16e594@gmail.com>
On Wed, 28 Dec 2022 22:30:56 +0100
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> There are still single reports of systems where ASPM incompatibilities
> cause tx timeouts. It's not clear whom to blame, so let's disable
> ASPM in case of a tx timeout.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Wouldn't a log message be appropriate here.
netdev_WARN_ONCE(tp->dev, "ASPM disabled on Tx timeout\n");
next prev parent reply other threads:[~2022-12-28 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 21:30 [PATCH net-next] r8169: disable ASPM in case of tx timeout Heiner Kallweit
2022-12-28 22:05 ` Stephen Hemminger [this message]
2022-12-29 11:30 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221228140509.21b14e7b@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).