From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC90C4332F for ; Thu, 29 Dec 2022 07:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbiL2HIf (ORCPT ); Thu, 29 Dec 2022 02:08:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231264AbiL2HId (ORCPT ); Thu, 29 Dec 2022 02:08:33 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EEA11274B for ; Wed, 28 Dec 2022 23:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672297664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bPu20pS/DdT91F8IydmlqqU8a82kyRMHKQeQqC1iCsQ=; b=OJ6pv0ogIB7Nb+/yKoZBRJYRJR23QtqtMlgChiDZ+22dzrivOfj8ibERC9lDOBzeLUiyLs o6LYJxxNKV3r66kPTSm58xhqQRos6KkTymObgaRWJzfsU5C7YFQmsszw64E+LiCr86TFRd 9IowozBdcJqhtbN7J19zEbX+ceLr+bY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-657-J_DcXZiePL6BTS4U6jPa-Q-1; Thu, 29 Dec 2022 02:07:42 -0500 X-MC-Unique: J_DcXZiePL6BTS4U6jPa-Q-1 Received: by mail-ed1-f69.google.com with SMTP id x13-20020a05640226cd00b0047ac11c9774so12320663edd.17 for ; Wed, 28 Dec 2022 23:07:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bPu20pS/DdT91F8IydmlqqU8a82kyRMHKQeQqC1iCsQ=; b=er9HHQv4rnoBsELIFBac+h6jnjes7najZTRTyipWedrjErF1mYhD2ct4kkwOPSb0Az TDpYpD7zAgHAD6mL4DZOZ1CZtif4Kx7WGdL4pRS9v8IoJRQLjhwb45Cjzl4vO4jLtZnF I3lJZjjyBotuS6iJdbb4a17ikSpQdbwcGQokRX28lnCvitzQTmIDcCUsxIPbhxq8FkjK bisqjhGQg20y8MUCVuZvoinK6mgu0COenguoRlQMzywz4CDjFRw6ZH/81GNi/NlKE2KL 8jc2MWV6m4cLYvbJ5PiQf3lHttExudeazn1aqcOqcd5hVHHYLAVdyik1E7d4vYsnwryP M4LA== X-Gm-Message-State: AFqh2kqnzjGNi1k/QTSZmCwzwnHY3pQWY4xsJvGWsWhBr9NxruhLqIdU 7Ywt7XRpTevTAptycltZh13Zy4wyndtaCca1r1GqLhEq673tsqjBCd/1lhIMmCcT7fhUwdmjDTc t+XpGaq86r8ewXdjs X-Received: by 2002:a17:906:298f:b0:7c0:fa2c:fc9b with SMTP id x15-20020a170906298f00b007c0fa2cfc9bmr25411322eje.55.1672297661226; Wed, 28 Dec 2022 23:07:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXuRUDqAyosWJYpOIWrOSpWIbCvCqFmJmOZzZEXMSAjeKwf2iMUA7V6PSBUnHR31Ghwj8Gddrg== X-Received: by 2002:a17:906:298f:b0:7c0:fa2c:fc9b with SMTP id x15-20020a170906298f00b007c0fa2cfc9bmr25411307eje.55.1672297660951; Wed, 28 Dec 2022 23:07:40 -0800 (PST) Received: from redhat.com ([2.52.151.85]) by smtp.gmail.com with ESMTPSA id b11-20020a17090630cb00b007c0f5d6f754sm8249151ejb.79.2022.12.28.23.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 23:07:40 -0800 (PST) Date: Thu, 29 Dec 2022 02:07:36 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, alvaro.karsz@solid-run.com, eperezma@redhat.com Subject: Re: [PATCH 3/4] virtio_ring: introduce a per virtqueue waitqueue Message-ID: <20221229020553-mutt-send-email-mst@kernel.org> References: <20221226074908.8154-1-jasowang@redhat.com> <20221226074908.8154-4-jasowang@redhat.com> <20221226183705-mutt-send-email-mst@kernel.org> <20221227022255-mutt-send-email-mst@kernel.org> <20221227043148-mutt-send-email-mst@kernel.org> <0d9f1b89-9374-747b-3fb0-b4b28ad0ace1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Dec 28, 2022 at 07:53:08PM +0800, Jason Wang wrote: > On Wed, Dec 28, 2022 at 2:34 PM Jason Wang wrote: > > > > > > 在 2022/12/27 17:38, Michael S. Tsirkin 写道: > > > On Tue, Dec 27, 2022 at 05:12:58PM +0800, Jason Wang wrote: > > >> 在 2022/12/27 15:33, Michael S. Tsirkin 写道: > > >>> On Tue, Dec 27, 2022 at 12:30:35PM +0800, Jason Wang wrote: > > >>>>> But device is still going and will later use the buffers. > > >>>>> > > >>>>> Same for timeout really. > > >>>> Avoiding infinite wait/poll is one of the goals, another is to sleep. > > >>>> If we think the timeout is hard, we can start from the wait. > > >>>> > > >>>> Thanks > > >>> If the goal is to avoid disrupting traffic while CVQ is in use, > > >>> that sounds more reasonable. E.g. someone is turning on promisc, > > >>> a spike in CPU usage might be unwelcome. > > >> > > >> Yes, this would be more obvious is UP is used. > > >> > > >> > > >>> things we should be careful to address then: > > >>> 1- debugging. Currently it's easy to see a warning if CPU is stuck > > >>> in a loop for a while, and we also get a backtrace. > > >>> E.g. with this - how do we know who has the RTNL? > > >>> We need to integrate with kernel/watchdog.c for good results > > >>> and to make sure policy is consistent. > > >> > > >> That's fine, will consider this. > > So after some investigation, it seems the watchdog.c doesn't help. The > only export helper is touch_softlockup_watchdog() which tries to avoid > triggering the lockups warning for the known slow path. I never said you can just use existing exporting APIs. You'll have to write new ones :) > And before the patch, we end up with a real infinite loop which could > be caught by RCU stall detector which is not the case of the sleep. > What we can do is probably do a periodic netdev_err(). > > Thanks Only with a bad device. > > >> > > >> > > >>> 2- overhead. In a very common scenario when device is in hypervisor, > > >>> programming timers etc has a very high overhead, at bootup > > >>> lots of CVQ commands are run and slowing boot down is not nice. > > >>> let's poll for a bit before waiting? > > >> > > >> Then we go back to the question of choosing a good timeout for poll. And > > >> poll seems problematic in the case of UP, scheduler might not have the > > >> chance to run. > > > Poll just a bit :) Seriously I don't know, but at least check once > > > after kick. > > > > > > I think it is what the current code did where the condition will be > > check before trying to sleep in the wait_event(). > > > > > > > > > >>> 3- suprise removal. need to wake up thread in some way. what about > > >>> other cases of device breakage - is there a chance this > > >>> introduces new bugs around that? at least enumerate them please. > > >> > > >> The current code did: > > >> > > >> 1) check for vq->broken > > >> 2) wakeup during BAD_RING() > > >> > > >> So we won't end up with a never woke up process which should be fine. > > >> > > >> Thanks > > > > > > BTW BAD_RING on removal will trigger dev_err. Not sure that is a good > > > idea - can cause crashes if kernel panics on error. > > > > > > Yes, it's better to use __virtqueue_break() instead. > > > > But consider we will start from a wait first, I will limit the changes > > in virtio-net without bothering virtio core. > > > > Thanks > > > > > > > > > >>>