* [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator
@ 2022-12-26 8:43 Daniil Tatianin
2022-12-30 2:22 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Daniil Tatianin @ 2022-12-26 8:43 UTC (permalink / raw)
To: netdev
Cc: Daniil Tatianin, linux-kernel, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Otherwise we would dereference a NULL aggregator pointer when calling
__set_agg_ports_ready on the line below.
Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
---
drivers/net/bonding/bond_3ad.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index acb6ff0be5ff..320e5461853f 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -1520,6 +1520,7 @@ static void ad_port_selection_logic(struct port *port, bool *update_slave_arr)
slave_err(bond->dev, port->slave->dev,
"Port %d did not find a suitable aggregator\n",
port->actor_port_number);
+ return;
}
}
/* if all aggregator's ports are READY_N == TRUE, set ready=TRUE
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator
2022-12-26 8:43 [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator Daniil Tatianin
@ 2022-12-30 2:22 ` Jakub Kicinski
2022-12-30 8:44 ` Daniil Tatianin
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2022-12-30 2:22 UTC (permalink / raw)
To: Daniil Tatianin
Cc: netdev, linux-kernel, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, David S. Miller, Eric Dumazet, Paolo Abeni
On Mon, 26 Dec 2022 11:43:53 +0300 Daniil Tatianin wrote:
> Otherwise we would dereference a NULL aggregator pointer when calling
> __set_agg_ports_ready on the line below.
Fixes tag, please?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator
2022-12-30 2:22 ` Jakub Kicinski
@ 2022-12-30 8:44 ` Daniil Tatianin
2022-12-31 3:55 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Daniil Tatianin @ 2022-12-30 8:44 UTC (permalink / raw)
To: Jakub Kicinski
Cc: netdev, linux-kernel, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, David S. Miller, Eric Dumazet, Paolo Abeni
On 12/30/22 5:22 AM, Jakub Kicinski wrote:
> On Mon, 26 Dec 2022 11:43:53 +0300 Daniil Tatianin wrote:
>> Otherwise we would dereference a NULL aggregator pointer when calling
>> __set_agg_ports_ready on the line below.
>
> Fixes tag, please?
Looks like this code was introduced with the initial git import.
Would that still be useful?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator
2022-12-30 8:44 ` Daniil Tatianin
@ 2022-12-31 3:55 ` Jakub Kicinski
2023-01-02 9:54 ` Daniil Tatianin
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2022-12-31 3:55 UTC (permalink / raw)
To: Daniil Tatianin
Cc: netdev, linux-kernel, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, David S. Miller, Eric Dumazet, Paolo Abeni
On Fri, 30 Dec 2022 11:44:02 +0300 Daniil Tatianin wrote:
> On 12/30/22 5:22 AM, Jakub Kicinski wrote:
> > On Mon, 26 Dec 2022 11:43:53 +0300 Daniil Tatianin wrote:
> >> Otherwise we would dereference a NULL aggregator pointer when calling
> >> __set_agg_ports_ready on the line below.
> >
> > Fixes tag, please?
> Looks like this code was introduced with the initial git import.
> Would that still be useful?
yessir, the point is to let backporters know how far the bug goes.
The initial import is our local equivalent of infinity, for all
practical purposes.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator
2022-12-31 3:55 ` Jakub Kicinski
@ 2023-01-02 9:54 ` Daniil Tatianin
0 siblings, 0 replies; 5+ messages in thread
From: Daniil Tatianin @ 2023-01-02 9:54 UTC (permalink / raw)
To: Jakub Kicinski
Cc: netdev, linux-kernel, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, David S. Miller, Eric Dumazet, Paolo Abeni
On 12/31/22 6:55 AM, Jakub Kicinski wrote:
> On Fri, 30 Dec 2022 11:44:02 +0300 Daniil Tatianin wrote:
>> On 12/30/22 5:22 AM, Jakub Kicinski wrote:
>>> On Mon, 26 Dec 2022 11:43:53 +0300 Daniil Tatianin wrote:
>>>> Otherwise we would dereference a NULL aggregator pointer when calling
>>>> __set_agg_ports_ready on the line below.
>>>
>>> Fixes tag, please?
>> Looks like this code was introduced with the initial git import.
>> Would that still be useful?
>
> yessir, the point is to let backporters know how far the bug goes.
> The initial import is our local equivalent of infinity, for all
> practical purposes.
Gotcha, thanks for letting me know!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-02 9:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-26 8:43 [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator Daniil Tatianin
2022-12-30 2:22 ` Jakub Kicinski
2022-12-30 8:44 ` Daniil Tatianin
2022-12-31 3:55 ` Jakub Kicinski
2023-01-02 9:54 ` Daniil Tatianin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).